Revert ensure-max-old-space now that node 12+ has better default memory ceilings #7677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry ceilings. This reverts jupyterlab#7201 as discussed in jupyterlab#7175 Fixes jupyterlab#7675
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
lock
bot
added
the
status:resolved-locked
|
This was reverted in #8083 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This reverts #7201 as discussed in #7175
Fixes #7675
Code changes
Deletes the ensure-max-old-space script as no longer needed with node 12+.
User-facing changes
Backwards-incompatible changes
We no longer default to 4G max of memory space. In node 12+, the max memory is set automatically, and for earlier node, the user will have to set a NODE_OPTIONS environment variable.