New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade yarn in staging to 1.21.1 #7691
Conversation
The latest yarn bump in the root package.json to 1.21.1 did not actually upgrade the yarn we ship. This upgrades the yarn we ship to yarn 1.21.1, using the distribution file https://github.com/yarnpkg/yarn/releases/download/v1.21.1/yarn-1.21.1.js (from the release notes https://github.com/yarnpkg/yarn/releases/tag/v1.21.1)
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
We deleted the yarn.lock, the ran `jlpm install`, then `jlpm run deduplicate`.
@blink1073 - I think this should be merged before the next beta release. |
I noticed this as well, and wondered what the deal was. Thanks for tackling it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @telamonian. @afshin, you were merging things recently. Is there a reason you didn't merge this? |
No, I just got caught up in other tasks! |
(And I was only looking at the PRs with green checkboxes and didn't re-run these to see if they pass.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers!
👍
References
The latest yarn bump in the root package.json to 1.21.1 did not actually upgrade the yarn we ship.
Fixes #7692
Code changes
This upgrades the yarn we ship to yarn 1.21.1, using the distribution file https://github.com/yarnpkg/yarn/releases/download/v1.21.1/yarn-1.21.1.js (from the release notes https://github.com/yarnpkg/yarn/releases/tag/v1.21.1)
User-facing changes
Backwards-incompatible changes