Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move vega from "devDependencies" to "dependencies" #7699

Merged
merged 1 commit into from Dec 29, 2019
Merged

Move vega from "devDependencies" to "dependencies" #7699

merged 1 commit into from Dec 29, 2019

Conversation

telamonian
Copy link
Member

References

fixes #7689

Code changes

Moved the vega dependencies in vega5-extension/package.json from "devDependencies" => "dependencies". This should fix the missing vega-embed bug, but it's a little bit hard to test.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@telamonian telamonian mentioned this pull request Dec 26, 2019
Closed
afshin
afshin approved these changes Dec 28, 2019
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the vega import in the src. Are the other two necessary because they are peer dependencies? (This looks good to me, if that is the case.)

@saulshanabrook
Copy link
Member

Are the other two necessary because they are peer dependencies?

Yep!

@afshin afshin merged commit 5942e1d into jupyterlab:master Dec 29, 2019
@afshin afshin changed the title moved vega deps from "devDependencies" => "dependencies" in package.json Move vega dependencies from "devDependencies" to "dependencies" Dec 30, 2019
@afshin afshin changed the title Move vega dependencies from "devDependencies" to "dependencies" Move vega from "devDependencies" to "dependencies" Dec 30, 2019
@afshin afshin mentioned this pull request Dec 30, 2019
Merged
4 tasks
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 30, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
@jasongrout jasongrout added this to the 2.0 milestone Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afshin afshin afshin approved these changes

Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

jupyter lab build does not work with 2.0.0b1
4 participants
@telamonian @saulshanabrook @afshin @jasongrout