Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jlicon migration #7700

Merged
merged 102 commits into from Jan 7, 2020
Merged

Jlicon migration #7700

merged 102 commits into from Jan 7, 2020

Commits on Jan 3, 2020

  1. starting work on JLIcon, to be used as an icon class wrapper

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    0f809bb View commit details
    Browse the repository at this point in the history

  2. dynamically create JLIcon class within a function

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    efa1d43 View commit details
    Browse the repository at this point in the history

  3. added static JLIcon.element, returns an HTMLElement

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    4f1638c View commit details
    Browse the repository at this point in the history

  4. set up ref forwarding in JLIcon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    8624db8 View commit details
    Browse the repository at this point in the history

  5. simplified typing of createIcon return type

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    c326626 View commit details
    Browse the repository at this point in the history

  6. all of the wrapped icons now get autogenerated by integrity 

    also had to revert the cleanup of createIcon's return type. The new
way didn't work since some template parameters weren't specified
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    f762440 View commit details
    Browse the repository at this point in the history

  7. added explicitly declared return type to createIcon 

    also added explicit types to the call to `React.forwardRef`
within `createIcon`
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    4539af9 View commit details
    Browse the repository at this point in the history

  8. simplified createIcon function by refactoring it into JLIcon class 

    individual icons are now instances of JLIcon class
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    268905d View commit details
    Browse the repository at this point in the history

  9. refactored JLIcon.react from accessor => property 

    more efficient, since this way the component returned by .react is
created only once (as part of the constructor) and cached. Need to be
careful with future changes to JLIcon.constructor, as execution order
of initializers is now important
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    d5b42f9 View commit details
    Browse the repository at this point in the history

  10. fixed up docstrings in JLIcon namespace

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    b6c3b38 View commit details
    Browse the repository at this point in the history

  11. experimenting with blending phosphor/react vdom

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    e75530c View commit details
    Browse the repository at this point in the history

  12. all tabbar icons now rendered by blended react/phosphor vdom elements 

    requires the changes in the phosphorjs/phosphor#437 PR
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    6c23a2d View commit details
    Browse the repository at this point in the history

  13. fixed sidebar tab icons; styling still isn't right 

    currently can't use two different styles for tab icons passed to phosphor.
Also in this commit: an experiment in constructing a bare svg react component
from a raw string (contained in jlicon.tsx)
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    536d45e View commit details
    Browse the repository at this point in the history

  14. integrity

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    0277f04 View commit details
    Browse the repository at this point in the history

  15. fixing up the text editor icon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    4e2df2f View commit details
    Browse the repository at this point in the history

  16. fixed text editor icon name

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    768125b View commit details
    Browse the repository at this point in the history

  17. progress fixing text editor icon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    cbd6730 View commit details
    Browse the repository at this point in the history

  18. finished fixing text editor icon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    b845879 View commit details
    Browse the repository at this point in the history

  19. human readability formatting pass of filetype icon svg 

    punted on issue of tabs-vs-spaces for indents
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    79469c6 View commit details
    Browse the repository at this point in the history

  20. switch filebrowser to newest JLIcon icon handling

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    a366024 View commit details
    Browse the repository at this point in the history

  21. finally got react to parse/render bare svg element without outer div

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    06c5173 View commit details
    Browse the repository at this point in the history

  22. bugfix for camelCase function

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    dd721e9 View commit details
    Browse the repository at this point in the history

  23. fixed container handling by JLIcon methods

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    36ac7f1 View commit details
    Browse the repository at this point in the history

  24. fixed styling of tab manager tab icons

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    9297f0c View commit details
    Browse the repository at this point in the history

  25. fixed memory leak in browser icons; updates for latest version of hpass

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    1704c4e View commit details
    Browse the repository at this point in the history

  26. fixed memory leak; JLIcon nows cleans up after itself when passed to … 

    …phosphor
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    68a43f1 View commit details
    Browse the repository at this point in the history

  27. post phosphor => lumino rebase cleanup

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    1771420 View commit details
    Browse the repository at this point in the history

  28. progress

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    036c9fd View commit details
    Browse the repository at this point in the history

  29. progress

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    34ca1ce View commit details
    Browse the repository at this point in the history

  30. JLIcon prototype is now feature complete and lumino vdom friendly

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    c7e5b82 View commit details
    Browse the repository at this point in the history

  31. type/signature fixes

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    22b0bf8 View commit details
    Browse the repository at this point in the history

  32. fixed bug in static Map init

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    6a048c3 View commit details
    Browse the repository at this point in the history

  33. fixed tabmanager icon styling

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    b6786ba View commit details
    Browse the repository at this point in the history

  34. fixed style for dockpanel tab icons

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    db35c74 View commit details
    Browse the repository at this point in the history

  35. signature cleanup

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    6796d22 View commit details
    Browse the repository at this point in the history

  36. simplified JLIcon styling for lumino; moved all tab icons to JLIcon 

    All filetype icons in tabs and all extension icons in the sidebar are now JLIcons
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    eb5bea3 View commit details
    Browse the repository at this point in the history

  37. docs and integrity

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    a882925 View commit details
    Browse the repository at this point in the history

  38. post-rebase cleanup and bugfixes

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    9bbc82f View commit details
    Browse the repository at this point in the history

  39. integrity

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    ed68067 View commit details
    Browse the repository at this point in the history

  40. picked lint

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    e46395c View commit details
    Browse the repository at this point in the history

  41. configure all linters to ignore generated iconimports.ts

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    6203578 View commit details
    Browse the repository at this point in the history

  42. began migrating batch of 17 icons from theme-x-extension to ui-compon… 

    …ents
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    57364cc View commit details
    Browse the repository at this point in the history

  43. continuing migration of batch of 17 icons

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    2e21f9a View commit details
    Browse the repository at this point in the history

  44. canonicalized names of migrated icons

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    981806c View commit details
    Browse the repository at this point in the history

  45. cleaned up/annotated migrated icon svgs

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    f535037 View commit details
    Browse the repository at this point in the history

  46. improved/robustified the JLIcon.get() icon lookup method

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    6369282 View commit details
    Browse the repository at this point in the history

  47. migrated icons in settingeditor pkg to JLIcon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    8d8bb4f View commit details
    Browse the repository at this point in the history

  48. migreated icons in filebrowser pkg to JLIcon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    81d9d81 View commit details
    Browse the repository at this point in the history

  49. prevent redundant rerenders of icons created by JLIcon.element()

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    836aac3 View commit details
    Browse the repository at this point in the history

  50. refactor of JLIcon.get into JLIcon.getElement and JLIcon.getReact

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    86a1053 View commit details
    Browse the repository at this point in the history

  51. removed all refs to defaultIconRegistry outside of ui-components pkgs

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    982a621 View commit details
    Browse the repository at this point in the history

  52. picked lint

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    0630035 View commit details
    Browse the repository at this point in the history

  53. fix filebrowser unittests

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    fc82b8d View commit details
    Browse the repository at this point in the history

  54. removed refs to defaultIconReact and IIconregistry from non ui-x pkgs

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    a7566c2 View commit details
    Browse the repository at this point in the history

  55. fixed icon label rendering bug

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    68a8c33 View commit details
    Browse the repository at this point in the history

  56. fixed icon titles

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    322c3e5 View commit details
    Browse the repository at this point in the history

  57. improve svg loader in storybook's webpack

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    880713e View commit details
    Browse the repository at this point in the history

  58. finished moving all icons from theme-x-extension => ui-components

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    1816b1d View commit details
    Browse the repository at this point in the history

  59. finished cleaning all icons out of theme-x-extension packages

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    5504391 View commit details
    Browse the repository at this point in the history

  60. fixed the names of the arrow icons

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    14b1201 View commit details
    Browse the repository at this point in the history

  61. fixed raw svg for arrow icons

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    fd73ffe View commit details
    Browse the repository at this point in the history

  62. migrated Collapse to JLIcon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    a22539d View commit details
    Browse the repository at this point in the history

  63. fix unittests

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    599304e View commit details
    Browse the repository at this point in the history

  64. fix usage CI

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    f80ab28 View commit details
    Browse the repository at this point in the history

  65. migrated all jupyter icon and most arrow icon usages to JLIcon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    73abf86 View commit details
    Browse the repository at this point in the history

  66. icon renaming

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    a634697 View commit details
    Browse the repository at this point in the history

  67. more icon renaming

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    c2779fd View commit details
    Browse the repository at this point in the history

  68. finished annotating all svg icons for themeability 

    possible I still missed a couple
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    36362ca View commit details
    Browse the repository at this point in the history

  69. improved JLIcon._get to allow for dynamic lookup on multiple classNames

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    5ae1436 View commit details
    Browse the repository at this point in the history

  70. ellipsis and circle icon migrated to JLIcon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    4dfb7e3 View commit details
    Browse the repository at this point in the history

  71. integrity

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    40d8438 View commit details
    Browse the repository at this point in the history

  72. migrated undo and finished migrating ellipsis icons to JLIcon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    52a078d View commit details
    Browse the repository at this point in the history

  73. integrity

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    c388056 View commit details
    Browse the repository at this point in the history

  74. fixes jupyterlab#7575: centered v alignment of breadcrumbs home icon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    ba65ce8 View commit details
    Browse the repository at this point in the history

  75. removed deprecated IconItem

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    b515336 View commit details
    Browse the repository at this point in the history

  76. migrated search icons 

    minor regressions in search icons and a couple of caret icons
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    385ef45 View commit details
    Browse the repository at this point in the history

  77. fixed search and caret icon visual regressions

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    b96a7fd View commit details
    Browse the repository at this point in the history

  78. removed deprecated "selected" versions of svg icons

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    f7bd783 View commit details
    Browse the repository at this point in the history

  79. migrated running item icons to JLIcon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    f749ef0 View commit details
    Browse the repository at this point in the history

  80. more icon cleanup and migration

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    7b6baee View commit details
    Browse the repository at this point in the history

  81. first pass at icon cleanup/migration finished

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    88fcf31 View commit details
    Browse the repository at this point in the history

  82. migrated select element icon to JLIcon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    d46084e View commit details
    Browse the repository at this point in the history

  83. added CSS for inverting icon colors, and for changing them on hover

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    47b0434 View commit details
    Browse the repository at this point in the history

  84. finished fixing/migrating the close icons

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    08173c5 View commit details
    Browse the repository at this point in the history

  85. set up all in one busy/close/close-circle icon

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    656d7f5 View commit details
    Browse the repository at this point in the history

  86. removed final vestiges of deprecated IconRegistry from codebase

    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    0718260 View commit details
    Browse the repository at this point in the history

  87. upgraded lumino deps to pull latest advances in virtualdom icon handling 

    tested the JLIcon stuff, appears to work well
    @telamonian
    telamonian committed Jan 3, 2020
    Copy the full SHA
    eb8c71d View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2020

  1. finished cleaning/migrating the caret icons

    @telamonian
    telamonian committed Jan 4, 2020
    Copy the full SHA
    b30f505 View commit details
    Browse the repository at this point in the history

  2. consolidated icon css in ui-components package

    @telamonian
    telamonian committed Jan 4, 2020
    Copy the full SHA
    d3ca2b8 View commit details
    Browse the repository at this point in the history

  3. finished cleaning up icons.css

    @telamonian
    telamonian committed Jan 4, 2020
    Copy the full SHA
    e98d72e View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. added jest-raw-loader to fix some issues with svg icon tests

    @telamonian
    telamonian committed Jan 6, 2020
    Copy the full SHA
    acd909b View commit details
    Browse the repository at this point in the history

  2. add data-icon attribute

    Steven Silvester committed Jan 6, 2020
    Copy the full SHA
    1ac461e View commit details
    Browse the repository at this point in the history

  3. Add a className to the breadcrump ellipsis

    Steven Silvester committed Jan 6, 2020
    Copy the full SHA
    fe9b305 View commit details
    Browse the repository at this point in the history

  4. Update tests

    Steven Silvester committed Jan 6, 2020
    Copy the full SHA
    a2accb9 View commit details
    Browse the repository at this point in the history

  5. integrity

    Steven Silvester committed Jan 6, 2020
    Copy the full SHA
    73b8970 View commit details
    Browse the repository at this point in the history

  6. fixed all tests in test-apputils

    @telamonian
    telamonian committed Jan 6, 2020
    Copy the full SHA
    532e8eb View commit details
    Browse the repository at this point in the history

  7. Merge branch 'jlicon_migration' of github.com:telamonian/jupyterlab i… 

    …nto jlicon_migration
    @telamonian
    telamonian committed Jan 6, 2020
    Copy the full SHA
    e57d80b View commit details
    Browse the repository at this point in the history

  8. post-merge fixes

    @telamonian
    telamonian committed Jan 6, 2020
    Copy the full SHA
    5aac0f3 View commit details
    Browse the repository at this point in the history

  9. Pin nbformat for now

    Steven Silvester committed Jan 6, 2020
    Copy the full SHA
    160d4de View commit details
    Browse the repository at this point in the history

  10. also pin nbformat in the windows CI

    @telamonian
    telamonian committed Jan 6, 2020
    Copy the full SHA
    240733b View commit details
    Browse the repository at this point in the history

  11. remove pins

    Steven Silvester committed Jan 6, 2020
    Copy the full SHA
    2e7be84 View commit details
    Browse the repository at this point in the history

  12. fix pipeline config

    Steven Silvester committed Jan 6, 2020
    Copy the full SHA
    6431b9b View commit details
    Browse the repository at this point in the history