Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change phosphor instructions to lumino for linking #7707

Merged
merged 1 commit into from Jan 1, 2020

Conversation

saulshanabrook
Copy link
Member

References

Follow up on #7582

Code changes

None

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

Thanks! In doing a word search for "phosphor" in the lab codebase, I found a dozen or so other mentions. Do you want to fix them too?

Copy link
Contributor

@tgeorgeux tgeorgeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afshin afshin merged commit 41689b2 into master Jan 1, 2020
@vidartf vidartf deleted the saulshanabrook-patch-1 branch January 1, 2020 13:32
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 31, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2020
@jasongrout jasongrout added this to the 2.0 milestone Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants