Fix handling of linked extensions #7728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Looks like it should work to me. Thanks! |
|
cc @kgryte this should help with our linked extensions issue we were having in datastore and remove need for verdaccio |
|
@meeseeksdev backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jan 16, 2020
blink1073
pushed a commit
that referenced
this pull request
Jan 16, 2020
…8-on-1.x Backport PR #7728 on branch 1.x (Fix handling of linked extensions)
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #6738
Code changes
Uses
resolutionsfor linked extensions and packages, so they do not need to be published tonpm. Also cleans up the handling of the creation of the packages instaging/linked_packages, which was sometimes resulting in the file not being populated there.User-facing changes
None
Backwards-incompatible changes
None