Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up handling of Icons under unified LabIcon #7767

Merged
merged 74 commits into from Feb 3, 2020
Merged

Clean up handling of Icons under unified LabIcon #7767

merged 74 commits into from Feb 3, 2020

Commits on Jan 18, 2020

  1. replaced JLIcon (and unwanted React sub-dep) in rendermime-interfaces

    @telamonian
    telamonian committed Jan 18, 2020
    Copy the full SHA
    40d8bc6 View commit details
    Browse the repository at this point in the history

  2. improved accuracy of IFileType.iconRenderer typing

    @telamonian
    telamonian committed Jan 18, 2020
    Copy the full SHA
    542a428 View commit details
    Browse the repository at this point in the history

  3. use render method for listings icons, simplify iconRenderer typing

    @telamonian
    telamonian committed Jan 18, 2020
    Copy the full SHA
    00adfd5 View commit details
    Browse the repository at this point in the history

  4. integrity

    @telamonian
    telamonian committed Jan 18, 2020
    Copy the full SHA
    076cc66 View commit details
    Browse the repository at this point in the history

  5. delinted

    @telamonian
    telamonian committed Jan 18, 2020
    Copy the full SHA
    5e2842e View commit details
    Browse the repository at this point in the history

  6. initital stab at minimal IJLIcon interface 

    current plan is to add to IJLIcon as the important bits of the JLIcon implementation get locked odwn
    @telamonian
    telamonian committed Jan 18, 2020
    Copy the full SHA
    b9aae6b View commit details
    Browse the repository at this point in the history

  7. bugfix

    @telamonian
    telamonian committed Jan 18, 2020
    Copy the full SHA
    fedda16 View commit details
    Browse the repository at this point in the history

  8. full revert of rendermime-interfaces; totally removed iconRenderer

    @telamonian
    telamonian committed Jan 18, 2020
    Copy the full SHA
    43570ea View commit details
    Browse the repository at this point in the history

  9. added namespacing to the JLIcon name prop

    @telamonian
    telamonian committed Jan 18, 2020
    Copy the full SHA
    b185d80 View commit details
    Browse the repository at this point in the history

  10. type cleanup

    @telamonian
    telamonian committed Jan 18, 2020
    Copy the full SHA
    ddfcada View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. fixed unittests to deal with icon namespacing

    @telamonian
    telamonian committed Jan 21, 2020
    Copy the full SHA
    77ae24e View commit details
    Browse the repository at this point in the history

  2. refined handling of icon container className

    @telamonian
    telamonian committed Jan 21, 2020
    Copy the full SHA
    49b3ffb View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. added icon: string | {name: string, svgstr: string} field

    @telamonian
    telamonian committed Jan 23, 2020
    Copy the full SHA
    30d390a View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. added JLIcon.resolve static method 

    also fixed/added a bunch of doc string to JLIcon
    @telamonian
    telamonian committed Jan 24, 2020
    Copy the full SHA
    346a52d View commit details
    Browse the repository at this point in the history

  2. added complete implementation of dynamic icon svg replacement

    @telamonian
    telamonian committed Jan 24, 2020
    Copy the full SHA
    8edce2f View commit details
    Browse the repository at this point in the history

  3. split out JLIcon.IRenderer from JLIcon

    @telamonian
    telamonian committed Jan 24, 2020
    Copy the full SHA
    11fa636 View commit details
    Browse the repository at this point in the history

  4. fixed up FileType handling to match new icon stuff

    @telamonian
    telamonian committed Jan 24, 2020
    Copy the full SHA
    a5ccf4f View commit details
    Browse the repository at this point in the history

  5. removed icon backwards compatibility shim from filebrowser listing

    @telamonian
    telamonian committed Jan 24, 2020
    Copy the full SHA
    6756532 View commit details
    Browse the repository at this point in the history

  6. some type fixes

    @telamonian
    telamonian committed Jan 24, 2020
    Copy the full SHA
    ebe90e8 View commit details
    Browse the repository at this point in the history

  7. small cleanup of vega icon svg

    @telamonian
    telamonian committed Jan 24, 2020
    Copy the full SHA
    884726d View commit details
    Browse the repository at this point in the history

  8. fixed up typings related to JLIcon.IRenderer; added lots of docstrings

    @telamonian
    telamonian committed Jan 24, 2020
    Copy the full SHA
    83111f6 View commit details
    Browse the repository at this point in the history

  9. untangled IFileType vs FileType mess in DocumentRegistry 

    - first commit since 30d390a for which jlab successfully builds

- still need to actually test out/run the code, see how many things the
    recent changes to icon handling broke
    @telamonian
    telamonian committed Jan 24, 2020
    Copy the full SHA
    65cdd2a View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2020

  1. picked lint

    @telamonian
    telamonian committed Jan 25, 2020
    Copy the full SHA
    b1a8127 View commit details
    Browse the repository at this point in the history

  2. IFileType.icon now working in rendermime-interfaces; 

    - fully functional example of `icon: string | {name, svgstr}` interface
can be found in (the rendermime-interfaces based) vega5-extension pkg

- initial testing indicates that the rest of the icons in jlab also
made it through the recent changes mostly (completely?) unscathed

- there do seem to be some real CI failures in test-docregistry
    @telamonian
    telamonian committed Jan 25, 2020
    Copy the full SHA
    cca887d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into remove-jlicon-rendermime-interfaces

    @telamonian
    telamonian committed Jan 25, 2020
    Copy the full SHA
    b54af80 View commit details
    Browse the repository at this point in the history

  4. added index.ts to src/style subpkg of ui-components

    @telamonian
    telamonian committed Jan 25, 2020
    Copy the full SHA
    5f22efd View commit details
    Browse the repository at this point in the history

  5. fixed external import of exports from src/style in ui-components pkg

    @telamonian
    telamonian committed Jan 25, 2020
    Copy the full SHA
    73b9252 View commit details
    Browse the repository at this point in the history

  6. added render-related fields to IFileType.icon interface

    @telamonian
    telamonian committed Jan 25, 2020
    Copy the full SHA
    5219caf View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2020

  1. removed outdated IconRegistry based stories

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    7ad325a View commit details
    Browse the repository at this point in the history

  2. added stories based on new JLIcon icons

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    52a6b68 View commit details
    Browse the repository at this point in the history

  3. cleanup for new story

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    be2f1ba View commit details
    Browse the repository at this point in the history

  4. cleanup of interfaces/types and related docstrings

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    67c8b8c View commit details
    Browse the repository at this point in the history

  5. bugfix to Renderer constructor signature typing

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    8c82f28 View commit details
    Browse the repository at this point in the history

  6. use full icon implementation for .icon field in docregistry

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    4f6c104 View commit details
    Browse the repository at this point in the history

  7. added icon upconversion to rendermime plugin creation routine

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    655a20f View commit details
    Browse the repository at this point in the history

  8. removed DocumentRegistry.FileType and reverts all usages to IFileType 

    - automagic upconversion of file type icons will now only occur for
the rendermime-interfaces version of IFileType.icon from
rendermime-interfaces. Conversely, all icons specified in the docregistry
version of IFileType.icon will need to be full JLIcon instances in the first
place
    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    126a78e View commit details
    Browse the repository at this point in the history

  9. bind passed render/unrender funcs in JLIcon constructor

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    9e51d8f View commit details
    Browse the repository at this point in the history

  10. minor cleanup of ensureUiComponents func

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    8964804 View commit details
    Browse the repository at this point in the history

  11. change all refs to iconRenderer => icon across codebase 

    - exception: refs to title.iconRenderer, where title is a Lumino Title obj, were left as-is
    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    554a73e View commit details
    Browse the repository at this point in the history

  12. fixed handling of compolex cases in JLIcon.resolve and .constructor

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    3923fe7 View commit details
    Browse the repository at this point in the history

  13. fixed up signature of IRenderer.render, can now flexibly take options 

    - related to code added to @lumino/virtualdom in jupyterlab/lumino#44. Once that's pulled in, the TODOs added in this PR will then be able to be cleared
    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    1cc6735 View commit details
    Browse the repository at this point in the history

  14. bugfix

    @telamonian
    telamonian committed Jan 26, 2020
    Copy the full SHA
    66bc3e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. refactored all refs JLIcon => LabIcon; still need to move jlicon.tsx

    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    43c0959 View commit details
    Browse the repository at this point in the history

  2. finished JLIcon => LabIcon refactor by moving jlicon.tsx => labicon.tsx

    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    1abde8d View commit details
    Browse the repository at this point in the history

  3. added functions to help render icon-as-css-background nodes 

    - also added some docs with a spec for how icon resolution is supposed to work
    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    9d393f9 View commit details
    Browse the repository at this point in the history

  4. added a LabIcon user guide

    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    6d75ad5 View commit details
    Browse the repository at this point in the history

  5. bugfix (for code) and formatting fix (for docs)

    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    1c10a5e View commit details
    Browse the repository at this point in the history

  6. added resolveElement and resolveReact static methods to LabIcon

    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    7a8eca5 View commit details
    Browse the repository at this point in the history

  7. fixed resolveX methods; removed getElement, marked getReact => UNSTABLE 

    - LabIcon.UNSTABLE_getReact needs to stick around for the moment to support 2 corner cases. The one in settingeditor is fixable (with a bit of work), but the one in launcher might be trickier, depending as it does on lumino's CommandRegistry
    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    8607a27 View commit details
    Browse the repository at this point in the history

  8. added the jupyter.lab.setting-icon field

    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    6671fc8 View commit details
    Browse the repository at this point in the history

  9. fixed up and simplified item icon handling in filebrowser listing 

    - also removed usage of iconStyle from filebrowser, with the eventual goal of returning this to a non-exported function local to the ui-components pkg
    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    a56f389 View commit details
    Browse the repository at this point in the history

  10. removed UNSTABLE_getReact from settingeditor 

    - now UNSTABLE_getReact is only needed for two usages in launcher
    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    000e153 View commit details
    Browse the repository at this point in the history

  11. fixed wrong casing in icon name "textEditor" => "text-editor" 

    - also, the icon import statements in iconimports.ts are now generated in alphabetical order
    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    097c987 View commit details
    Browse the repository at this point in the history

  12. bugfix; was passing extraneous props into LabIcon.resolveX methods

    @telamonian
    telamonian committed Jan 27, 2020
    Copy the full SHA
    51c281b View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. iconClass => iconName conversion shim mostly removed; one special case 

    - the shim has been removed from the normal code path and incorporated into UNSTABLE_getReact
- still need the shim in two instances in the launcher pkg
    @telamonian
    telamonian committed Jan 28, 2020
    Copy the full SHA
    617c2bd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into remove-jlicon-rendermime-interfaces

    @telamonian
    telamonian committed Jan 28, 2020
    Copy the full SHA
    59b2713 View commit details
    Browse the repository at this point in the history

  3. adding optional fallback arg to LabIcon.resolveX methods

    @telamonian
    telamonian committed Jan 28, 2020
    Copy the full SHA
    46543f5 View commit details
    Browse the repository at this point in the history

  4. added in test-ui-components, build broken, need to fix

    @telamonian
    telamonian committed Jan 28, 2020
    Copy the full SHA
    3316ea1 View commit details
    Browse the repository at this point in the history

  5. bugfix

    @telamonian
    telamonian committed Jan 28, 2020
    Copy the full SHA
    433ce6a View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2020

  1. implemented fallback arg for LabIcon.resolveX methods 

    - also bugfix in svg replacement routine
    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    2de04f2 View commit details
    Browse the repository at this point in the history

  2. README now has just user docs; all dev docs now in CONTRIBUTING

    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    d3b84f8 View commit details
    Browse the repository at this point in the history

  3. iconStyle no longer exported; exposed LabIcon.UNSTABLE_style to replace

    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    7f464d3 View commit details
    Browse the repository at this point in the history

  4. removed last vestige of iconClass => icon name shim, with one exception 

    - sole exception: UNSTABLE_getReact
    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    f2fd38d View commit details
    Browse the repository at this point in the history

  5. added first actual unittest to test-ui-components

    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    6877db5 View commit details
    Browse the repository at this point in the history

  6. integrity

    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    c384fc7 View commit details
    Browse the repository at this point in the history

  7. removed stranded if (icon) statement

    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    0170ca8 View commit details
    Browse the repository at this point in the history

  8. better test icons for test-ui-components, care of @tgeorgeux

    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    e465195 View commit details
    Browse the repository at this point in the history

  9. alphabetized existing extension point docs

    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    b221606 View commit details
    Browse the repository at this point in the history

  10. added Icon section to extension points docs

    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    6e53b50 View commit details
    Browse the repository at this point in the history

  11. added note/link about LabIcon to extension migration docs

    @telamonian
    telamonian committed Jan 29, 2020
    Copy the full SHA
    6ec8cf3 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. fix docs and add changelog entry

    Steven Silvester committed Jan 30, 2020
    Copy the full SHA
    b03c8d3 View commit details
    Browse the repository at this point in the history

  2. update ci_script

    Steven Silvester committed Jan 30, 2020
    Copy the full SHA
    19e94a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2020

  1. fixed typing error wrt latest lumino; removed unsafe widening of IRen… 

    …derer
    @telamonian
    telamonian committed Feb 3, 2020
    Copy the full SHA
    947f932 View commit details
    Browse the repository at this point in the history

  2. allow other svg attributes in test

    Steven Silvester committed Feb 3, 2020
    Copy the full SHA
    282584c View commit details
    Browse the repository at this point in the history