Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change dark theme to be based on AYU #7779

Closed
wants to merge 2 commits into from
Closed

Change dark theme to be based on AYU #7779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
984ecee
change dark style to be based on AYU
wolfv Jan 13, 2020
74db4c3
linted files
wolfv Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/codemirror/style/base.css
View file
Open in desktop
Expand Up @@ -231,3 +231,14 @@
.cm-s-jupyter .CodeMirror-gutter {
background-color: var(--jp-layout-color2);
}

.cm-s-jupyter .CodeMirror-matchingbracket {
color: var(--jp-mirror-editor-matchingbracket);
}
.cm-s-jupyter .CodeMirror-nonmatchingbracket {
color: var(--jp-mirror-editor-nonmatchingbracket);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that (surprisingly), we weren't able to customize these before. Nice improvement!


.cm-s-jupyter .CodeMirror-matchingtag {
background: var(--jp-mirror-editor-matchingtag);
}
66 changes: 34 additions & 32 deletions packages/theme-dark-extension/style/variables.css
View file
Open in desktop
Expand Up @@ -199,11 +199,11 @@ all of MD as it is not optimized for dense, information rich UIs.
* theme these would go from light to dark.
*/

--jp-layout-color0: #111111;
--jp-layout-color1: var(--md-grey-900);
--jp-layout-color2: var(--md-grey-800);
--jp-layout-color0: #0a0e14;
--jp-layout-color1: #131b26;
--jp-layout-color2: #202d40;
--jp-layout-color3: var(--md-grey-700);
--jp-layout-color4: var(--md-grey-600);
--jp-layout-color4: #b3b1ad;

/* Inverse Layout
*
Expand Down Expand Up @@ -332,37 +332,39 @@ all of MD as it is not optimized for dense, information rich UIs.

/* General editor styles */

--jp-editor-selected-background: var(--jp-layout-color2);
--jp-editor-selected-background: #273747;
--jp-editor-selected-focused-background: rgba(33, 150, 243, 0.24);
--jp-editor-cursor-color: var(--jp-ui-font-color0);

/* Code mirror specific styles */

--jp-mirror-editor-keyword-color: var(--md-green-500);
--jp-mirror-editor-atom-color: var(--md-blue-300);
--jp-mirror-editor-number-color: var(--md-green-400);
--jp-mirror-editor-def-color: var(--md-blue-600);
--jp-mirror-editor-variable-color: var(--md-grey-300);
--jp-mirror-editor-variable-2-color: var(--md-blue-400);
--jp-mirror-editor-variable-3-color: var(--md-green-600);
--jp-mirror-editor-punctuation-color: var(--md-blue-400);
--jp-mirror-editor-property-color: var(--md-blue-400);
--jp-mirror-editor-operator-color: #aa22ff;
--jp-mirror-editor-comment-color: #408080;
--jp-mirror-editor-string-color: #ba2121;
--jp-mirror-editor-string-2-color: var(--md-purple-300);
--jp-mirror-editor-meta-color: #aa22ff;
--jp-mirror-editor-qualifier-color: #555;
--jp-mirror-editor-builtin-color: var(--md-green-600);
--jp-mirror-editor-bracket-color: #997;
--jp-mirror-editor-tag-color: var(--md-green-700);
--jp-mirror-editor-attribute-color: var(--md-blue-700);
--jp-mirror-editor-header-color: var(--md-blue-500);
--jp-mirror-editor-quote-color: var(--md-green-300);
--jp-mirror-editor-link-color: var(--md-blue-700);
--jp-mirror-editor-error-color: #f00;
--jp-editor-cursor-color: #e6b450;

--jp-mirror-editor-keyword-color: #ff8f40;
--jp-mirror-editor-atom-color: #ae81ff;
--jp-mirror-editor-number-color: #e6b450;
--jp-mirror-editor-def-color: #ffee99;
--jp-mirror-editor-variable-color: #b3b1ad;
--jp-mirror-editor-variable-color-2: #f07178;
--jp-mirror-editor-variable-color-3: #39bae6;
--jp-mirror-editor-punctuation-color: #ae81ff;
--jp-mirror-editor-property-color: #ffb454;
--jp-mirror-editor-operator-color: #ff8f40;
--jp-mirror-editor-comment-color: #ffb454;
--jp-mirror-editor-string-color: #c2d94c;
--jp-mirror-editor-string-2-color: #b3b1ad;
--jp-mirror-editor-meta-color: #b3b1ad;
--jp-mirror-editor-qualifier-color: #b3b1ad;
--jp-mirror-editor-builtin-color: #e6b450;
--jp-mirror-editor-bracket-color: #f8f8f2;
--jp-mirror-editor-tag-color: rgba(57, 186, 230, 80);
--jp-mirror-editor-attribute-color: #ffb454;
--jp-mirror-editor-header-color: #c2d94c;
--jp-mirror-editor-quote-color: #b3b1ad;
--jp-mirror-editor-link-color: #39bae6;
--jp-mirror-editor-error-color: #ff3333;
--jp-mirror-editor-hr-color: #999;

--jp-mirror-editor-matchingbracket: #ff8f40;
--jp-mirror-editor-nonmatchingbracket: #ff8f40;
--jp-mirror-editor-matchingtag: #ff8f40;

/* Vega extension styles */

--jp-vega-background: var(--md-grey-400);
Expand Down