Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post LabIcon cleanup; migrate last holdouts to LabIcon; fix icon styling #7864

Merged
merged 47 commits into from Feb 24, 2020
Merged

Post LabIcon cleanup; migrate last holdouts to LabIcon; fix icon styling #7864

merged 47 commits into from Feb 24, 2020

Commits on Feb 22, 2020

  1. fixed react icon for vdom filetype

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    c47c998 View commit details
    Browse the repository at this point in the history

  2. migrated commands/menu items in filebrowser-extension to LabIcon

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    a0b1522 View commit details
    Browse the repository at this point in the history

  3. integrity

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    0d30a6c View commit details
    Browse the repository at this point in the history

  4. filebrowser-extension: all icons now LabIcon, .iconRenderer => .icon 

    fixes needed:
    - menu icon styling
    - open with submenu icons
    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    fbc97bd View commit details
    Browse the repository at this point in the history

  5. notebook-extension: all icons now LabIcon, .iconRenderer => .icon

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    3ef132b View commit details
    Browse the repository at this point in the history

  6. terminal-extension: all icons now LabIcon, .iconRenderer => .icon

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    7f04236 View commit details
    Browse the repository at this point in the history

  7. migrated all refs to deprecated title.iconRenderer => title.icon

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    af6053e View commit details
    Browse the repository at this point in the history

  8. add LabIcon.renderer method to allow for binding props/styles to icons 

    - also fixed up rendering of iconLabel passed in from lumino
    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    6b5a6c8 View commit details
    Browse the repository at this point in the history

  9. removes all uses of LabIcon.UNSTABLE_style from shell.ts

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    cd74323 View commit details
    Browse the repository at this point in the history

  10. refactored renderer => bindprops

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    06300f6 View commit details
    Browse the repository at this point in the history

  11. bindprops partially working

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    c0c5b89 View commit details
    Browse the repository at this point in the history

  12. LabIcon.bindprops now works as intended

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    fbc4289 View commit details
    Browse the repository at this point in the history

  13. added styling for filebrowser context menu item icons

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    0a51bbd View commit details
    Browse the repository at this point in the history

  14. all filebrowser context menu item icons now migrated => LabIcon. 

    - There seems to be a bug related to how menu items get "recycled"; some icons are getting screwed up after multiple openings and closings of different context menus
    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    f81b4a1 View commit details
    Browse the repository at this point in the history

  15. fixed use of addIcon

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    99e054d View commit details
    Browse the repository at this point in the history

  16. fixed replace toggle button icon in find/replace widget

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    cd1325a View commit details
    Browse the repository at this point in the history

  17. fixed all launcher icons; removed all UNSTABLE methods from LabIcon

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    4c64ecd View commit details
    Browse the repository at this point in the history

  18. removed Private.nameToClassName from labicon.tsx

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    677339c View commit details
    Browse the repository at this point in the history

  19. simplified icon resolvability check

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    d62afc0 View commit details
    Browse the repository at this point in the history

  20. added temp fix (until lumino 2.0) for getting iconClass from a command

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    63237c9 View commit details
    Browse the repository at this point in the history

  21. finished audit of all uses of iconClass in jlab core src

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    6e481ec View commit details
    Browse the repository at this point in the history

  22. starting to fix menu icons

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    8bdb70b View commit details
    Browse the repository at this point in the history

  23. integrity

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    cae9a04 View commit details
    Browse the repository at this point in the history

  24. fixed menu item check marks. all menu icon issues fixed

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    4336f54 View commit details
    Browse the repository at this point in the history

  25. bugfix for disabled submenu caret. Some submenu icons not working

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    e74e56e View commit details
    Browse the repository at this point in the history

  26. added MenuSvg.insertItem hack to workaround submenu renderer issue

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    e41db4c View commit details
    Browse the repository at this point in the history

  27. fixed check mark icons in CommandPaletteSvg

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    f9b53c9 View commit details
    Browse the repository at this point in the history

  28. CommandPalette header icon mostly fixed, some minor styling bugs remain

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    4e75f14 View commit details
    Browse the repository at this point in the history

  29. fixed styling for CommandPalette header icon

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    1cdb766 View commit details
    Browse the repository at this point in the history

  30. created/added clearIcon

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    04688da View commit details
    Browse the repository at this point in the history

  31. integrity

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    bae948a View commit details
    Browse the repository at this point in the history

  32. grouped Widget subclasses tweaked for svg icons into widgets subpkg

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    8db32e3 View commit details
    Browse the repository at this point in the history

  33. bumped lumino deps to latest, needed for icon/virtualdom fixes

    @telamonian
    telamonian committed Feb 22, 2020
    Copy the full SHA
    8e2b243 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2020

  1. fixed icon kind docstrings

    @telamonian
    telamonian committed Feb 23, 2020
    Copy the full SHA
    96ca4ca View commit details
    Browse the repository at this point in the history

  2. cleaned up icon styling system

    @telamonian
    telamonian committed Feb 23, 2020
    Copy the full SHA
    5a0a51b View commit details
    Browse the repository at this point in the history

  3. plugged new icon styling system into the rest of the program

    @telamonian
    telamonian committed Feb 23, 2020
    Copy the full SHA
    2ae36a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. fixes for/streamling of icon style merging

    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    996ead6 View commit details
    Browse the repository at this point in the history

  2. fix to statusBar icon style; removed default elementPosition

    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    72ba558 View commit details
    Browse the repository at this point in the history

  3. deprecated justify => elementPosition across codebase 

    - also added some stuff to .prettierignore, etc to protect my ide
files (esp local history in `.history`) from the linters
    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    c89aaac View commit details
    Browse the repository at this point in the history

  4. implemented elementSize icon styling arg 

    - `elementSize` can be set to eg 'normal' for standard 16px x 16px icon
    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    3099c28 View commit details
    Browse the repository at this point in the history

  5. massive fixup of icon styling-related docstrings

    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    8e63e3e View commit details
    Browse the repository at this point in the history

  6. moved currently unused Renderers into Private namespace

    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    fd332d1 View commit details
    Browse the repository at this point in the history

  7. deprecated/replaced kind => stylesheet across codebase

    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    f7fdeca View commit details
    Browse the repository at this point in the history

  8. fix for small regression in settings editor icon style/spacing

    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    48651c2 View commit details
    Browse the repository at this point in the history

  9. remove deprecated rendererClass from LabIcon.IOptions

    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    e6a179f View commit details
    Browse the repository at this point in the history

  10. critical bugfix to icon style caching 

    - bug could have caused a cached stylesheet to be incorrectly reused
    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    1834e6b View commit details
    Browse the repository at this point in the history

  11. audited icon css across the codebase

    @telamonian
    telamonian committed Feb 24, 2020
    Copy the full SHA
    267ee49 View commit details
    Browse the repository at this point in the history