Close Dialog by clicking ouside of it #7885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes a model/dialog by clicking the greyed out area outside of it. This functionality is the same as if the user clicked the esc key.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
This ended up being a tiny change after I looked into it for a while. I believe @blink1073 was the last to touch this code. @tgeorgeux is this what you were thinking, or do you want the "click outside the dialog" functionality to be more than just "do the same as clicking escape"? |
|
Oh, wow, thanks for fixing this. I didn't realize this wasn't happening already. I tried it and it looks like it is working well. |
jasongrout
approved these changes
Feb 14, 2020
|
That's exactly the behavior I was looking for! Thanks @ajbozarth |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #3784
Code changes
Closes a model/dialog by clicking the greyed out area outside of it.
This functionality is the same as if the user clicked the esc key.
This also addresses an undiscovered bug: Currently if a user clicks outside a dialog all the keyboard related events (escape, enter, tab) stop working until the user interacts with the dialog again (eg. changing a form value). This is "fixed" since clicking outside now closes the dialog.
User-facing changes
UX change: clicking outside a dialog closes it rather than doing nothing.
Backwards-incompatible changes
N/A