Throttle fetch requests in the setting registry's data connector #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Dependencies updated. @ikiw, you'll need to run the following to update dependencies: jlpm run update:dependency @lumino/polling ^latest
jlpm run update:dependency @lumino/datagrid ^latest |
|
@ikiw I rebased against |
afshin
changed the title
|
Docs failure is probably related to: jupyterlab/pytest-check-links#7 |
saulshanabrook
approved these changes
Mar 25, 2020
|
Tested this in Binder, looks like it properly throttles!
|
|
@meeseeksdev backport to 2.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Mar 30, 2020
…egistry's data connector
saulshanabrook
added a commit
that referenced
this pull request
Mar 30, 2020
…7-on-2.0.x Backport PR #7927 on branch 2.0.x (Throttle fetch requests in the setting registry's data connector)
saulshanabrook
added a commit
that referenced
this pull request
Mar 30, 2020
… the setting registry's data connector)"
saulshanabrook
added a commit
that referenced
this pull request
Mar 30, 2020
…-pr-7927-on-2.0.x Revert "Backport PR #7927 on branch 2.0.x (Throttle fetch requests in the setting registry's data connector)"
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor PR #7879 to use throttler
References
#7879
Code changes
Refactor of older PR #7879, to make use of Throttler in this use case as it solves the purpose of executing the callback only once even though invoked multiple times and making the code more cleaner.
Code change depends on jupyterlab/lumino#54 @afshin
User-facing changes
Backwards-incompatible changes
NO