Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified during iteration in upgrade extension #9550

Closed
agoose77 opened this issue Jan 5, 2021 · 0 comments · Fixed by #9551
Closed

Modified during iteration in upgrade extension #9550

agoose77 opened this issue Jan 5, 2021 · 0 comments · Fixed by #9551
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@agoose77
Copy link
Contributor

agoose77 commented Jan 5, 2021

for (key, value) in data[name].items():
if key.startswith('@phosphor/'):
has_phosphor = True
data[name][key.replace('@phosphor/', '@lumino/')] = value

We should take a copy of the items view to prevent this
for (key, value) in list(data[name].items())

blink1073 added a commit that referenced this issue Jan 5, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jul 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant