Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9550 in upgrade_extension.py #9551

Merged
merged 1 commit into from Jan 5, 2021
Merged

Fix #9550 in upgrade_extension.py #9551

merged 1 commit into from Jan 5, 2021

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Jan 5, 2021 •
edited

References

Fixes #9550

Code changes

Iterate over copy of items iterable.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

blink1073
blink1073 approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 3.0 milestone Jan 5, 2021
@blink1073 blink1073 merged commit 22f33da into jupyterlab:master Jan 5, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jul 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Modified during iteration in upgrade extension
2 participants
@agoose77 @blink1073