Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of empty CSV files #9557

Merged
merged 4 commits into from Jan 6, 2021
Merged

Fix parsing of empty CSV files #9557

merged 4 commits into from Jan 6, 2021

Commits on Jan 5, 2021

  1. Reproduce failure of DSVModel to parse empty file

    @krassowski
    krassowski committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    cab94f3 View commit details
    Browse the repository at this point in the history

  2. Fix parsing of empty CSV files

    @krassowski
    krassowski committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    45df277 View commit details
    Browse the repository at this point in the history

  3. Make the initial rowCount 0 in the CSV viewer model. 

    Also, handle the case when we get zero rows back from the parser, for the cases of empty files.
    @jasongrout
    jasongrout committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    bcb5d04 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Simplify logic by changing ‘reparse’ to the number of rows we request… 

    … to reparse.
    @jasongrout
    jasongrout committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    c0f4a8a View commit details
    Browse the repository at this point in the history