Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumb links #9572

Merged
merged 2 commits into from Jan 8, 2021
Merged

Fix breadcrumb links #9572

merged 2 commits into from Jan 8, 2021

Conversation

jasongrout
Copy link
Contributor

References

See readthedocs/sphinx_rtd_theme#1010. This should fix our linkcheck test.

Code changes

Apply upstream changes to our templates.

User-facing changes

Backwards-incompatible changes

@jasongrout jasongrout added this to the 3.0 milestone Jan 8, 2021
@jasongrout jasongrout changed the title Fix breadcrumb links. Fix breadcrumb links Jan 8, 2021
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio
Copy link
Member

jtpio commented Jan 8, 2021

This should fix our linkcheck test

Indeed it does, thanks!

image

@jtpio
Copy link
Member

jtpio commented Jan 8, 2021

Looks like the lint failure is not related and might come from #9557?

@jasongrout jasongrout merged commit d8d6f91 into jupyterlab:master Jan 8, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jul 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants