Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRenderer cleanup; normalize icon fields across all interfaces #46

Merged
merged 13 commits into from Feb 10, 2020
Merged

IRenderer cleanup; normalize icon fields across all interfaces #46

merged 13 commits into from Feb 10, 2020

Commits on Feb 7, 2020

  1. added some vscode stuff to gitignore

    @telamonian
    telamonian committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    92a305c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2020

  1. added iconRenderer field to command and menu item

    @telamonian
    telamonian committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    20fc19d View commit details
    Browse the repository at this point in the history

  2. deprecated title.iconRenderer in favor of reclaimed title.icon

    @telamonian
    telamonian committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    de6c338 View commit details
    Browse the repository at this point in the history

  3. switched .iconRenderer => .icon in commands and menu items

    @telamonian
    telamonian committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    16cfe95 View commit details
    Browse the repository at this point in the history

  4. minor fix to title constructor

    @telamonian
    telamonian committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    410c3dd View commit details
    Browse the repository at this point in the history

  5. small type fix (added | undefined)

    @telamonian
    telamonian committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    76f6766 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. fixed tests for tabbar and title

    @telamonian
    telamonian committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    4b64274 View commit details
    Browse the repository at this point in the history

  2. fixed tests for menu

    @telamonian
    telamonian committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    e6acd5c View commit details
    Browse the repository at this point in the history

  3. updated renderIcon for menubar to use title.icon

    @telamonian
    telamonian committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    b068940 View commit details
    Browse the repository at this point in the history

  4. updated renderItemIcon for commandpalette to use command.icon

    @telamonian
    telamonian committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    dfa9a72 View commit details
    Browse the repository at this point in the history

  5. attrs and children now passed consistently to custom vdom renderers

    @telamonian
    telamonian committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    d06928e View commit details
    Browse the repository at this point in the history

  6. added test coverage for Title.icon backwards compatibility

    @telamonian
    telamonian committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    fdcc50b View commit details
    Browse the repository at this point in the history

  7. added test coverage for CommandRegistry.icon backwards compatibility

    @telamonian
    telamonian committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    c8284df View commit details
    Browse the repository at this point in the history