-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs site to pyodide-kernel 0.6.0, update/pin demo deps #1031
base: main
Are you sure you want to change the base?
Conversation
@@ -1183,6 +1248,52 @@ def get_deps(has_deps, dep_file): | |||
|
|||
dep_file.write_text(out, **C.ENC) | |||
|
|||
def deps_to_wheels(all_deps): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should try to move the handling of the Pyodide examples to the jupyterlite-pyodide-kernel
repository at some point. But still include them on the demo site (https://jupyterlite.rtfd.io/en/latest/).
Hoping we could avoid growing this dodo.py
at some point, it feels more complex the more I look at it :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the handling
Sure, packaging the depfinder
stuff is fine, and while it would be separately-released, also be co-developed in the kernel repo.
avoid growing this dodo.py
Sure, that's fine: but it's still a complex, long build, and relying on docs just isn't worth the time keeping the docs up-to-date, and telling people where to look for them when they hit a problem which we know is a problem. And not all these things can be solved by more
The few, non-pyodide-related file_dep
s restored in this PR (e.g. "do a dev install when pyproject.toml
changes", or "build the app bundle before running the unit tests"), mean one can run doit check
and get a fully built docs site, which rebuilds correctly when things change. That, day-in, day-out simplicity is worth the complication in this one file. Heck, we should have the ui-tests in the loop as well, and use the output of those tests in documentation. More complex, but breaks the build in a good way if things change too much.
I've been making some progress on a tool that moves a lot of the grunt work of defining tasks and dependencies to some declarative pyproject.toml
, which could eventually be employed here.
@@ -1506,6 +1650,13 @@ def _ensure_resolutions(app_name): | |||
|
|||
return all_up_to_date | |||
|
|||
def fetch_pyodide_repodata(): | |||
url = "https://cdn.jsdelivr.net/pyodide/v0.23.0/full/repodata.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm does that means we also need to know the Pyodide version here? Which is already handled in https://github.com/jupyterlite/pyodide-kernel.
Looks like one more piece of configuration that will need to be updated next time we update the pyodide kernel.
Yeah should move those closer.
Or we actually install it, and grab it from the schema.
…On Fri, Mar 31, 2023, 11:26 Jeremy Tuloup ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dodo.py
<#1031 (comment)>
:
> @@ -1506,6 +1650,13 @@ def _ensure_resolutions(app_name):
return all_up_to_date
+ def fetch_pyodide_repodata():
+ url = "https://cdn.jsdelivr.net/pyodide/v0.23.0/full/repodata.json"
Hmm does that means we also need to know the Pyodide version here? Which
is already handled in https://github.com/jupyterlite/pyodide-kernel.
Looks like one more piece of configuration that will need to be updated
next time we update the pyodide kernel.
—
Reply to this email directly, view it on GitHub
<#1031 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRHFX5WGZ4JJ6X3E6ZDW64ASPANCNFSM6AAAAAAWOCRO5E>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
References
Code changes
pyodide-kernel
usejupyterlite-pyodide-kernel
from RTDpyodide-kernel 0.6.0
from githubjupyterlab_widgets
andipywidgets
to match now-tighter version rangesjuyterlab-myst
(causes lab UI css jank, huge up-front download)@jupyterlab/markedparser-extension
ipyvue
1.8.0
ipyvuetify
1.8.4
User-facing changes
Backwards-incompatible changes