Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run UI tests on webkit #1190

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Run UI tests on webkit #1190

wants to merge 3 commits into from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 4, 2023

References

Investigate #944

Code changes

Run UI tests on webkit to catch potential issues with Safari.

  • Add webkit to the test matrix
  • Add webkit reference snapshots

User-facing changes

TBD

Backwards-incompatible changes

None

@jtpio jtpio added this to the 0.2.0 milestone Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

lite-badge 👈 Try it on ReadTheDocs

@jtpio
Copy link
Member Author

jtpio commented Oct 4, 2023

At least the setImmediate issue mentioned in #944 is reproducible on CI:

image

@jtpio
Copy link
Member Author

jtpio commented Oct 4, 2023

So the "Basic code execution" test seems to be passing:

image

Which is about executing the JavaScript notebook, with the JavaScript kernel also running in a web worker:

test('Basic code execution', async ({ page }) => {
await page.goto('lab/index.html');
const name = 'javascript.ipynb';
await page.filebrowser.open(name);
await page.notebook.run();
await page.notebook.save();
const output = await page.notebook.getCellTextOutput(2);
expect(output).toBeTruthy();
});

So maybe the setImmediate issue is only for the Pyodide kernel. We can check if that also happens with the Xeus Python kernel on webkit to narrow it down more.

@jtpio
Copy link
Member Author

jtpio commented Oct 13, 2023

For reference the PR to test jupyterlite-xeus-python on webkit: jupyterlite/xeus-python-kernel#175

@jtpio jtpio modified the milestones: 0.2.0, 0.2.x Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant