Provide the server router from a token rather than an app attribute #1285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes partly #1284. The next step is to make the
JupyterFrontEnd
more composable to allow dropping the namespacing separation between JupyterLite and JupyterLab/Notebook.The goal is for third-party developer to be able to hook part of their Jupyter extension into the JupyterLiteServer without additional burden of namespacing plugins (what can be lifted if the Lumino
Application
is changed to a composition of plugins).Code changes
Make the server request router available from a token.
User-facing changes
None
Backwards-incompatible changes
None - the
router
attribute has been marked as deprecated but not removed.