Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the server router from a token rather than an app attribute #1285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fcollonval
Copy link
Contributor

References

Fixes partly #1284. The next step is to make the JupyterFrontEnd more composable to allow dropping the namespacing separation between JupyterLite and JupyterLab/Notebook.

The goal is for third-party developer to be able to hook part of their Jupyter extension into the JupyterLiteServer without additional burden of namespacing plugins (what can be lifted if the Lumino Application is changed to a composition of plugins).

Code changes

Make the server request router available from a token.

User-facing changes

None

Backwards-incompatible changes

None - the router attribute has been marked as deprecated but not removed.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

lite-badge 👈 Try it on ReadTheDocs

@fcollonval fcollonval marked this pull request as draft January 8, 2024 13:55
@fcollonval fcollonval marked this pull request as ready for review January 8, 2024 14:18
@jtpio jtpio added this to the 0.2.x milestone Jan 15, 2024
@jtpio
Copy link
Member

jtpio commented Jan 15, 2024

Thanks @fcollonval for looking into this!

The goal is for third-party developer to be able to hook part of their Jupyter extension into the JupyterLiteServer without additional burden of namespacing plugins (what can be lifted if the Lumino Application is changed to a composition of plugins).

Curious if being able to swap the router can already be useful to third-party extensions? Compared to being able to swap the in-browser services (sessions, kernels, contents...), which should already be possible? (just wondering about potential use cases).

@fcollonval
Copy link
Contributor Author

Curious if being able to swap the router can already be useful to third-party extensions?

You mean accessing the JupyterLite router to extend it, not providing an alternative implementation?

If so, yes it will answer the question. But the challenge that we should lift is the namespacing of plugins. For example, how would you provide the router that is part of JupyterLite server plugins space? Going that road seems more complex and hacky than removing the namespacing following the ability to customize upstream the service manager in the lab application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants