Windows build using Docker #1302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @savakarrohan. Maybe there should also be a CI job to make sure the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Attempting to solve #560 which talks about having a windows build system.
I am seeing the solution to #560 which is a problem related to filenames in Windows being a hamper for building easily. Thus proposing to have a Dockerfile/container which users can use for building.
I can take a look into adding to the documentation this aspect of the build process if you are interested.
Code changes
Adds a Dockerfile for building an image to be used for building using the current documentation on any platform.
User-facing changes
None
Backwards-incompatible changes
None