Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLab 4.2 and Notebook 7.2 #1376

Merged
merged 16 commits into from
May 21, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 18, 2024

References

Update to JupyterLab 4.2 and Notebook 7.2 pre-releases.

JupyterLab changelog: https://jupyterlab.readthedocs.io/en/latest/getting_started/changelog.html#v4-2

Code changes

  • Update @jupyterlab packages
  • Update @jupyter-notebook packages
  • Update @lumino packages
  • Add new core plugins and extensions
  • Update migration guide

User-facing changes

Re-open recently closed files

image

Dark High Contrast Theme

image

Full notebook windowing mode by default

image

Backwards-incompatible changes

Should be none.

Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@jtpio jtpio added the enhancement New feature or request label Apr 18, 2024
@jtpio jtpio added this to the 0.4.0 milestone Apr 18, 2024
@jtpio jtpio marked this pull request as ready for review May 17, 2024 14:44
@jtpio
Copy link
Member Author

jtpio commented May 17, 2024

Looks like CI is now passing, and looking good on RTD (see screenshots above).

Will aim for a first 0.4.0 pre-release early next week.

Copy link
Contributor

@Carreau Carreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

this._currentChanged.emit({
newValue: widget,
oldValue: previousWidget,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -66,7 +66,7 @@ test.describe('Kernels', () => {
.locator(`.jp-RunningSessions-item.jp-mod-kernel >> text="${name}"`)
.waitFor();
await page.locator('.jp-RunningSessions-item.jp-mod-kernel').first().hover();
await page.getByTitle('Shut Down Kernel').first().click();
await page.getByTitle('Shut Down').first().click();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jtpio
Copy link
Member Author

jtpio commented May 21, 2024

Thanks @Carreau for the review!

@jtpio jtpio merged commit 6e48856 into jupyterlite:main May 21, 2024
20 checks passed
@jtpio jtpio deleted the update-lab-42-nb72 branch May 21, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants