-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JupyterLab 4.2 and Notebook 7.2 #1376
Conversation
Looks like CI is now passing, and looking good on RTD (see screenshots above). Will aim for a first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me.
this._currentChanged.emit({ | ||
newValue: widget, | ||
oldValue: previousWidget, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -66,7 +66,7 @@ test.describe('Kernels', () => { | |||
.locator(`.jp-RunningSessions-item.jp-mod-kernel >> text="${name}"`) | |||
.waitFor(); | |||
await page.locator('.jp-RunningSessions-item.jp-mod-kernel').first().hover(); | |||
await page.getByTitle('Shut Down Kernel').first().click(); | |||
await page.getByTitle('Shut Down').first().click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks @Carreau for the review! |
References
Update to JupyterLab 4.2 and Notebook 7.2 pre-releases.
JupyterLab changelog: https://jupyterlab.readthedocs.io/en/latest/getting_started/changelog.html#v4-2
Code changes
@jupyterlab
packages@jupyter-notebook
packages@lumino
packagesUser-facing changes
Re-open recently closed files
Dark High Contrast Theme
Full notebook windowing mode by default
Backwards-incompatible changes
Should be none.