-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Make REPL URL params extensible #525
base: main
Are you sure you want to change the base?
Conversation
…dd-url-param-manager
Will probably block on this until #528 is ready, as would like to do the test app with |
I kinda wonder if our tests fail on windows because them temp dir is too long to delete... |
The more I've been tinkering with this, the more I'm thinking:
So: maybe this should hang off
So in the near term, I might split off some of the enablers of this work which are orthogonal to the actual param API:
|
This sounds good. It would be better for the existing parameters like |
References
IURLParamManager
#503Code changes
IReplApi
as an exposed service in a new pluginuse the schema for validation, defaultsjupyter lite serve
to allow re-embedding self?localforage-memoryStorageDriver
to allow iframes, because other drivers don't work?User-facing changes
Backwards-incompatible changes
Notes
theme
plugin acts a little funny, and calls itself very earlyResponsiveToolbar
leads to it collapsing at weird times (it has a 500ms debouncer that's hard to reason about)...
button that reveals the toolbar is actually really awesome, but doesn't quite do the right thing