-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JupyterLab Workspaces in Lab #805
base: main
Are you sure you want to change the base?
Conversation
Will a user be able to havr two different workspaces open in different browser tabs for the same jupyterlite environment? |
) | ||
) | ||
|
||
if C.CI and not C.CHECKING_RELEASE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we still need to run this in the check release workflow to make sure resolutions have been updated and not leave a git dirty state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... i guess i though that check-release should be allowed to changes things, while "plain old lint" should just fail hard if a new package gets added, for example (which is what bit me)
Thanks @bollwyvl for working on this. I did a quick check on RTD and there seems to be an issue with RetroLab. Here is what it looks like: workspaces-retro.mp4 |
Thanks for the thorough review. Need to sit back and take another look at it... maybe a path forward is for me to split up the |
Bumping to |
Yeah, would be good to get back to this. Does nb7 use workspace for e.g.
sidebars?
|
Notebook 7 does not use workspaces at the moment. I think this was discussed recently. Probably it won't make it for 7.0, but could be considered for 7.x (as long as we don't create another JupyterLab). |
References
Code changes
package.json
andtsconfig.json
actions indoit repo
prettier-package.json
doit repo
to lintingsettings
,contents
to use common configurableIForager
wrapper/api/workspaces/*
handlerslocalForage
drivers
andstorageName
injupyter-lite.json
/api/workspaces/all.json
?mode=single-document
to be set by URL parameterIRouter
to add transformingIWindowResolver
to handle the lack of real server without overloading all ofStateDB
jupyter_build_config.json
against given files/folders?jupyter-lite.json
.jupyterlab-workspace
files?goto('lab/index.html?reset')
instead ofpage.reload
in some existing testsexamples
siteUser-facing changes
/lab/
, existing windows should be re-opened?clone=default-6123123
Backwards-incompatible changes