Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependencies #112

Merged
merged 27 commits into from Dec 11, 2022
Merged

build(deps): update dependencies #112

merged 27 commits into from Dec 11, 2022

Conversation

SanchithHegde
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

This PR performs some dependency updates which have been pending since quite some time.

In addition, this PR removes some of our unused dependencies. @jarnura let me know if any of the dependencies are actually required, I couldn't find any usages of those crates, so I removed them.

The following dependencies are yet to be updated though. If we do update any of these, we end up receiving a clippy::unreachable warning, as mentioned in tokio-rs/tracing#2270 (comment).

router's dependencies yet to be updated:

Crate Old Version Compatible Version Latest
actix-cors 0.6.3 0.6.4 0.6.4
aws-config 0.49.0 0.49.0 0.51.0
aws-sdk-kms 0.19.0 0.19.0 0.21.0
reqwest 0.11.12 0.11.13 0.11.13

router_env's dependencies yet to be updated:

Crate Old Version Compatible Version Latest
tracing 0.1.36 0.1.37 0.1.37
tracing-actix-web 0.6.1 0.6.2 0.6.2
tracing-subscriber 0.3.15 0.3.16 0.3.16

We have four options to address this:

  1. Wait for a new tracing release.
  2. Use tracing as a git dependency, which would require us to include backwards incompatible changes meant to go in tracing v0.2.
  3. Fork tracing, backport PR 2356 to the v0.1.x branch and use it as a git dependency until a new version of tracing is out.
  4. Add a crate-wide #![allow(clippy::unreachable)] directive.

I'm very much against option 4; a viable solution is option 3 if we must update all dependencies to their latest versions. Let me know what would be preferable according to you.

Motivation and Context

Staying up-to-date.

How did you test it?

Compilation checks using cargo clippy and cargo hack check.

Checklist

  • I formatted the code cargo +nightly fmt
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SanchithHegde SanchithHegde added A-dependencies Area: Dependencies S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 11, 2022
@SanchithHegde SanchithHegde self-assigned this Dec 11, 2022
This MSRV bump is required because the `gethostname` crate has bumped its MSRV to 1.64 in `v0.4.0`.
Copy link
Member

@jarnura jarnura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarnura jarnura merged commit 585858e into main Dec 11, 2022
@jarnura jarnura deleted the dependency-updates branch December 11, 2022 18:43
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants