feat(payout): [Payone] add payone connector #4553

KiranKBR · 2024-05-06T06:16:03Z

Type of Change

Description

Payone is Payout connector and I have implemented payout fulfill flow

How did you test it?

I tested them through postman and here these are the requests and responses
Merchant Connector:

--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
    "connector_type": "payout_processor",
    "connector_name": "payone",
    "connector_account_details": {
        "auth_type": "SignatureKey",
        "api_key": "",
        "api_secret": "",
        "key1": ""
    },
    "test_mode": false,
    "disabled": false,
    "business_country": "US",
    "business_label": "default",
    "payment_methods_enabled": [
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "credit",
                    "card_networks": [
                        
                
                        "Mastercard",
                        "Visa"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "debit",
                    "card_networks": [
                        "AmericanExpress",
                        "Discover",
                        "Interac",
                        "JCB",
                        "Mastercard",
                        "Visa",
                        "DinersClub",
                        "UnionPay",
                        "RuPay"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "wallet",
            "payment_method_types": [
                {
                    "payment_method_type": "paypal",
                    "payment_experience": "redirect_to_url",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": false,
                    "installment_payment_enabled": false
                }
            ]
        }
    ],
    "metadata": {
        "city": "NY",
        "unit": "245"
    }
}'

response:

{
    "connector_type": "payout_processor",
    "connector_name": "payone",
    "connector_label": "payone_US_default",
    "merchant_connector_id": "mca_Rufh4UB4ctrHhOV8JQzG",
    "profile_id": "pro_cp4l2sD7NggkM66Cvrfz",
    "connector_account_details": {
        "auth_type": "SignatureKey",
        "api_key": "",
        "api_secret": "",
        "key1": ""
    },
    "payment_methods_enabled": [
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "credit",
                    "payment_experience": null,
                    "card_networks": [
                        "Mastercard",
                        "Visa"
                    ],
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "debit",
                    "payment_experience": null,
                    "card_networks": [
                        "AmericanExpress",
                        "Discover",
                        "Interac",
                        "JCB",
                        "Mastercard",
                        "Visa",
                        "DinersClub",
                        "UnionPay",
                        "RuPay"
                    ],
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "wallet",
            "payment_method_types": [
                {
                    "payment_method_type": "paypal",
                    "payment_experience": "redirect_to_url",
                    "card_networks": null,
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": false,
                    "installment_payment_enabled": false
                }
            ]
        }
    ],
    "connector_webhook_details": null,
    "metadata": {
        "city": "NY",
        "unit": "245"
    },
    "test_mode": false,
    "disabled": false,
    "frm_configs": null,
    "business_country": "US",
    "business_label": "default",
    "business_sub_label": null,
    "applepay_verified_domains": null,
    "pm_auth_config": null,
    "status": "active"
}

Payout Creation:

{
    "amount": 100,
    "currency": "EUR",
    "customer_id": "payout_customer",
    "email": "payout_customer@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payout request",
    "payout_type": "card",
    "payout_method_data": {
        "card": {
            "card_number": "4012000033330026",
            "expiry_month": "05",
            "expiry_year": "30",
            "card_holder_name": "John Smith"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "NY",
            "zip": "94122",
            "country": "US",
            "first_name": "John",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "entity_type": "Individual",
    "recurring": false,
    "metadata": {
        "ref": "123"
    },
        "business_country": "US",
    "business_label": "default",
    // "routing": {
    //     "type": "single",
    //     "data": "adyen"
    // },
    "auto_fulfill": true,
    "confirm": true
}

response:

{
    "payout_id": "5ec9e6ac-1bbc-4236-a217-e0ff890e7f2e",
    "merchant_id": "merchant_1715339934",
    "amount": 100,
    "currency": "EUR",
    "connector": "payone",
    "payout_type": "card",
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "NY",
            "first_name": "John",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "customer_id": "payout_customer",
    "auto_fulfill": true,
    "email": "payout_customer@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "client_secret": null,
    "return_url": null,
    "business_country": "US",
    "business_label": "default",
    "description": "Its my first payout request",
    "entity_type": "Individual",
    "recurring": false,
    "metadata": {
        "ref": "123"
    },
    "status": "success",
    "error_message": null,
    "error_code": null,
    "profile_id": "pro_cp4l2sD7NggkM66Cvrfz",
    "created": "2024-05-10T11:25:54.497Z"
}

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

4902

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

Sakilmostak · 2024-05-06T18:19:47Z

Required CI checks are failing, could you address that

…one-payout-flows

SamraatBansal · 2024-05-23T12:06:58Z

crates/router/src/connector/payone.rs

+                    message: errors
+                        .iter()
+                        .map(|error| format!("{} : {}", error.code, error.message))
+                        .collect::<Vec<_>>()


Define the type of the vector

SamraatBansal · 2024-05-23T12:07:23Z

crates/router/src/connector/payone.rs

+                        errors
+                            .iter()
+                            .map(|error| format!("{} : {}", error.code, error.message))
+                            .collect::<Vec<_>>()


Define the type of the vector

SamraatBansal · 2024-05-23T12:08:08Z

crates/router/src/connector/payone.rs

+                let code = first_error.map(|error| error.code.clone());
+                Ok(ErrorResponse {
+                    status_code: res.status_code,
+                    code: code.unwrap_or_else(|| consts::NO_ERROR_CODE.to_string()),


Discuss with @sai-harsha-vardhan , how retries work, and then decide how the error_code should be populated

SamraatBansal · 2024-05-23T12:15:02Z

crates/router/src/connector/payone/transformers.rs

+            _ => Err(errors::ConnectorError::NotImplemented(
+                get_unimplemented_payment_method_error_message("Payone"),
+            ))?,
+        }


Remove this default

SamraatBansal · 2024-05-23T12:15:44Z

crates/router/src/connector/payone/transformers.rs

+                    },
+                    PayoutMethodData::Bank(_) | PayoutMethodData::Wallet(_) => {
+                        Err(errors::ConnectorError::NotImplemented(
+                            get_unimplemented_payment_method_error_message("Payout"),


Suggested change

get_unimplemented_payment_method_error_message("Payout"),

get_unimplemented_payment_method_error_message("Payone"),

…one-payout-flows

crates/router/src/utils.rs

crates/router/src/connector/utils.rs

crates/router/src/connector/payone.rs

crates/common_utils/src/macros.rs

SanchithHegde · 2024-05-28T12:08:36Z

crates/router/src/macros.rs

+        let format = time::macros::format_description!($date_format);
+        time::OffsetDateTime::now_utc()
+            .format(&format)
+            .change_context(errors::ConnectorError::InvalidDateFormat)


Would have preferred using the fully qualified name for this error usage: router::core::errors::ConnectorError.

KiranKBR requested review from a team as code owners May 6, 2024 06:16

KiranKBR changed the title ~~(feat) : [Payone Payout] added flows~~ feat(payout): [Payone] May 6, 2024

KiranKBR changed the title ~~feat(payout): [Payone]~~ feat(payout): [Payone] add payone connector May 6, 2024

KiranKBR linked an issue May 7, 2024 that may be closed by this pull request

Fix deserialization errors for sdk_eligible_payment_methods #4566

Closed

2 tasks

KiranKBR added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels May 7, 2024

KiranKBR self-assigned this May 7, 2024

KiranKBR removed a link to an issue May 7, 2024

Fix deserialization errors for sdk_eligible_payment_methods #4566

Closed

2 tasks

KiranKBR and others added 6 commits May 7, 2024 15:52

added template code for payone

b4474f4

feat: added flows

7cde54e

refactored

c7c1247

chore: run formatter

b0432a0

clippy issues solved

93c5ce0

resolved conflicts

4a9d2b1

KiranKBR force-pushed the payone-payout-flows branch from 59714bb to 4a9d2b1 Compare May 7, 2024 10:59

KiranKBR and others added 2 commits May 8, 2024 11:58

Merge branch 'main' of https://github.com/juspay/hyperswitch into pay…

1c4a6ac

…one-payout-flows

chore: run formatter

e772fd9

KiranKBR added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 8, 2024

KiranKBR added 2 commits May 8, 2024 13:05

resolved MSRV

4b55833

date functions removed

48b86b2

KiranKBR changed the base branch from main to payone-template-code May 8, 2024 09:22

KiranKBR requested review from a team as code owners May 8, 2024 09:22

Sakilmostak previously approved these changes May 22, 2024

View reviewed changes

SamraatBansal requested changes May 23, 2024

View reviewed changes

comments resolved

8b7a35b

KiranKBR dismissed Sakilmostak’s stale review via 8b7a35b May 23, 2024 13:57

ConnectorErrorTypeMapping for payone

ce8e06f

KiranKBR force-pushed the payone-payout-flows branch from 1e02c9f to ce8e06f Compare May 23, 2024 15:16

Merge branch 'main' of https://github.com/juspay/hyperswitch into pay…

1e5a738

…one-payout-flows

kashif-m previously approved these changes May 24, 2024

View reviewed changes

SamraatBansal previously approved these changes May 26, 2024

View reviewed changes

SanchithHegde reviewed May 27, 2024

View reviewed changes

crates/router/src/utils.rs Outdated Show resolved Hide resolved

crates/router/src/connector/utils.rs Outdated Show resolved Hide resolved

crates/router/src/connector/payone.rs Show resolved Hide resolved

crates/router/src/connector/payone.rs Show resolved Hide resolved

get_formatted_date_time macro defined

892f9df

KiranKBR dismissed stale reviews from SamraatBansal and kashif-m via 892f9df May 27, 2024 14:10

SanchithHegde reviewed May 27, 2024

View reviewed changes

crates/common_utils/src/macros.rs Outdated Show resolved Hide resolved

moved to connector utils from common_utils

ee125bb

KiranKBR force-pushed the payone-payout-flows branch from db4c30d to ee125bb Compare May 28, 2024 06:17

SamraatBansal previously approved these changes May 28, 2024

View reviewed changes

SanchithHegde reviewed May 28, 2024

View reviewed changes

add qualified import crate::core::errors::ConnectorError

dc3aadc

KiranKBR dismissed SamraatBansal’s stale review via dc3aadc May 29, 2024 06:05

KiranKBR added 3 commits May 29, 2024 11:51

remove qualified import

1c6501e

add qualified import crate::core::errors::ConnectorError

2b419d8

add qualified import

7b86957

SanchithHegde approved these changes May 29, 2024

View reviewed changes

SamraatBansal approved these changes May 30, 2024

View reviewed changes

likhinbopanna added this pull request to the merge queue May 30, 2024

Merged via the queue into main with commit 832968c May 30, 2024
10 checks passed

likhinbopanna deleted the payone-payout-flows branch May 30, 2024 09:57

SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(payout): [Payone] add payone connector #4553

feat(payout): [Payone] add payone connector #4553

KiranKBR commented May 6, 2024 •

edited

Sakilmostak commented May 6, 2024

SamraatBansal May 23, 2024

SamraatBansal May 23, 2024

SamraatBansal May 23, 2024

SamraatBansal May 23, 2024

SamraatBansal May 23, 2024

SanchithHegde May 28, 2024

	get_unimplemented_payment_method_error_message("Payout"),
	get_unimplemented_payment_method_error_message("Payone"),

feat(payout): [Payone] add payone connector #4553

feat(payout): [Payone] add payone connector #4553

Conversation

KiranKBR commented May 6, 2024 • edited

Type of Change

Description

How did you test it?

Additional Changes

Motivation and Context

Checklist

Sakilmostak commented May 6, 2024

SamraatBansal May 23, 2024

Choose a reason for hiding this comment

SamraatBansal May 23, 2024

Choose a reason for hiding this comment

SamraatBansal May 23, 2024

Choose a reason for hiding this comment

SamraatBansal May 23, 2024

Choose a reason for hiding this comment

SamraatBansal May 23, 2024

Choose a reason for hiding this comment

SanchithHegde May 28, 2024

Choose a reason for hiding this comment

KiranKBR commented May 6, 2024 •

edited