fix(core): use realip_remote_addr function to extract ip address
#4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
added
C-bug
lsampras
previously approved these changes
May 15, 2024
sai-harsha-vardhan
previously approved these changes
May 15, 2024
Narayanbhat166
dismissed stale reviews from sai-harsha-vardhan and lsampras
via
8f47547
lsampras
approved these changes
May 16, 2024
hrithikesh026
approved these changes
May 16, 2024
sai-harsha-vardhan
approved these changes
May 16, 2024
SanchithHegde
removed
the
S-waiting-on-review
kashif-m
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Previously we were relying on the
X_FORWARDED_FORheader value for extracting the ip address. This value would be available if there were proxies that populate this value. But if this has been done from the localhost or if there were no reverse proxies behind the application, then this header value would not be present. This has been fixed in this PR.We are using the
realip_remote_addrfunction to extract the ip address from the request. This will look for theX_FORWARDED_FORheader, if not found, fallback to the socket ip address.Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy