feat(middleware): log content_length for 4xx #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
added
the
S-waiting-on-review
SanchithHegde
previously approved these changes
May 16, 2024
sai-harsha-vardhan
previously approved these changes
May 16, 2024
SanchithHegde
approved these changes
May 16, 2024
sai-harsha-vardhan
approved these changes
May 16, 2024
Comment on lines
+263
to
+286
|
|
||
| let content_length_header = new_req | ||
| .headers() | ||
| .get(headers::CONTENT_LENGTH) | ||
| .map(ToOwned::to_owned); | ||
| let response_fut = svc.call(new_req); | ||
| let response = response_fut.await?; | ||
| // Log the request_details when we receive 400 status from the application | ||
| if response.status() == 400 { | ||
| let request_id = request_id_fut.await?.as_hyphenated().to_string(); | ||
| let content_length_header_string = content_length_header | ||
| .map(|content_length_header| { | ||
| content_length_header.to_str().map(ToOwned::to_owned) | ||
| }) | ||
| .transpose() | ||
| .map_err(|error| { | ||
| logger::warn!("Could not convert content length to string {error:?}"); | ||
| error | ||
| }) | ||
| .ok() | ||
| .flatten(); | ||
|
|
||
| logger::info!("Content length from header: {content_length_header_string:?}, Bytes length: {bytes_length}"); | ||
|
|
There was a problem hiding this comment.
Have a look at pub fn get_header_value_by_key(key: String, headers: &HeaderMap)
SanchithHegde
removed
the
S-waiting-on-review
kashif-m
pushed a commit
that referenced
this pull request
May 20, 2024
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
In case of 4xx, we need to log the content length of the request from the
content-lengthheader. This PR adds that enhancement.Motivation and Context
To provide better support for debugging issues related to missing fields.
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy