Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): update TS module resolution flow #1659

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Apr 4, 2024

  1. fix(common): update TS module resolution flow

    This commit updates the implementation for resolving `.ts` files.
    Instead of registering the `ts-node` project only once, we now refrain from
    doing so since there might be multiple projects with different configurations.
    The current approach involves dynamically switching the implementation for
    registering and unregistering the project after the `.ts` file has been transpiled
    and resolved. This change addresses an issue where warnings were encountered when
    `ts-node` attempted to register with different configurations. The number of configurations
    is no longer a concern, as each time we need to read a `.ts` file, a new TS project is
    registered. This adjustment does not impact performance or other attributes because `ts-node`
    allows native project disabling. Part of the implementation has been adapted from what Nrwl Nx
    already has; we can find their implementation here:
    https://github.com/nrwl/nx/blob/master/packages/nx/src/plugins/js/utils/register.ts
    It's worth noting that their implementation is somewhat versatile, as it also supports SWC.
    
    Closes: #1197
    Closes: #1213
    Closes: #1730
    arturovt committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e02da5d View commit details
    Browse the repository at this point in the history