Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f-header@v10.20.0 Stop Portugal, Romania, and New Zealand support & adding Slovakia country #2529

Merged
merged 4 commits into from
May 21, 2024
Merged

f-header@v10.20.0 Stop Portugal, Romania, and New Zealand support & adding Slovakia country #2529

merged 4 commits into from
May 21, 2024

Conversation

phatpt8
Copy link
Contributor

@phatpt8 phatpt8 commented May 17, 2024 •
edited

This is the standard PR description template.

  • Remove usages of any code related to decommissioned countries (PT, RO, and NZ)
  • Adding new country Slovakia

UI Review Checks

  • Remove PL, RO, NZ:
Screenshot 2024-05-17 at 13 43 09
  • Adding SK (Slovakia)
Screenshot 2024-05-17 at 15 43 33
  • README and/or UI Documentation has been [created|updated]
  • Unit tests have been [created|updated]
  • This code has been checked with regard to our accessibility standards

Browsers Tested

  • Chrome (latest)
  • Internet Explorer 11
  • Mobile (Please list device/browser – Ideally one iPhone model and one Android)

List any other browsers that this PR has been tested in:

@github-actions github-actions bot added the organisms This PR changes at least one "organism" component label May 17, 2024
@phatpt8 phatpt8 changed the title f-header@10:20:0: Stop Portugal, Romania, and New Zealand support f-header@v10:20:0: Stop Portugal, Romania, and New Zealand support May 17, 2024
@phatpt8 phatpt8 changed the title f-header@v10:20:0: Stop Portugal, Romania, and New Zealand support f-header@v10.20.0: Stop Portugal, Romania, and New Zealand support May 17, 2024
@phatpt8 phatpt8 changed the title f-header@v10.20.0: Stop Portugal, Romania, and New Zealand support f-header@v10.20.0 Stop Portugal, Romania, and New Zealand support May 17, 2024
@phatpt8 phatpt8 marked this pull request as ready for review May 17, 2024 14:44
@phatpt8 phatpt8 changed the title f-header@v10.20.0 Stop Portugal, Romania, and New Zealand support f-header@v10.20.0 Stop Portugal, Romania, and New Zealand support & adding Slovakia country May 17, 2024
@jamieomaguire jamieomaguire self-requested a review May 21, 2024 09:02
jamieomaguire
jamieomaguire requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@jamieomaguire jamieomaguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phatpt8 is going to look into why the countries order may have changed

@jamieomaguire jamieomaguire merged commit 50ec7e3 into master May 21, 2024
21 checks passed
@jamieomaguire jamieomaguire deleted the wcp-944-f-header-updates branch May 21, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandel10n dandel10n dandel10n left review comments

@ashleynolan ashleynolan ashleynolan approved these changes

@jamieomaguire jamieomaguire jamieomaguire approved these changes

Assignees
No one assigned
Labels
organisms This PR changes at least one "organism" component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phatpt8 @ashleynolan @jamieomaguire @dandel10n