add handling of lone commas when destructuring arrays

This handles ignored elements as per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment#Ignoring_some_returned_values Closes eslint#12756
justincorrigible · Jan 10, 2020 · b05010c · b05010c
1 parent 9dfc850
commit b05010c
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/lib/rules/comma-style.js b/lib/rules/comma-style.js
@@ -127,7 +127,7 @@ module.exports = {
          * @returns {void}
          * @private
          */
-        function validateCommaItemSpacing(previousItemToken, commaToken, currentItemToken, reportItem) {
+        function validateCommaItemSpacing(previousItemToken, commaToken, currentItemToken, reportItem, arrayPattern) {
 
             // if single line
             if (astUtils.isTokenOnSameLine(commaToken, currentItemToken) &&
@@ -144,7 +144,7 @@ module.exports = {
                     : "between";
 
                 // lone comma
-                context.report({
+                arrayPattern || context.report({
                     node: reportItem,
                     loc: {
                         line: commaToken.loc.end.line,
@@ -185,9 +185,10 @@ module.exports = {
          */
         function validateComma(node, property) {
             const items = node[property],
-                arrayLiteral = (node.type === "ArrayExpression" || node.type === "ArrayPattern");
+                arrayLiteral = node.type === "ArrayExpression",
+                arrayPattern = node.type === "ArrayPattern";
 
-            if (items.length > 1 || arrayLiteral) {
+            if (items.length > 1 || arrayLiteral || arrayPattern) {
 
                 // seed as opening [
                 let previousItemToken = sourceCode.getFirstToken(node);
@@ -213,7 +214,7 @@ module.exports = {
                      */
                     if (astUtils.isCommaToken(commaToken)) {
                         validateCommaItemSpacing(previousItemToken, commaToken,
-                            currentItemToken, reportItem);
+                            currentItemToken, reportItem, arrayPattern);
                     }
 
                     if (item) {
@@ -226,13 +227,12 @@ module.exports = {
                 });
 
                 /*
-                 * Special case for array literals that have empty last items, such
+                 * Special case for arrays that have empty last items, such
                  * as [ 1, 2, ]. These arrays only have two items show up in the
                  * AST, so we need to look at the token to verify that there's no
                  * dangling comma.
                  */
-                if (arrayLiteral) {
-
+                if (arrayLiteral || arrayPattern) {
                     const lastToken = sourceCode.getLastToken(node),
                         nextToLastToken = sourceCode.getTokenBefore(lastToken);