URI Retriever: follow http redirects using Curl by default #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/http-redirects
branch
from
19e56cd
to
3fa45eb
Compare
soyuka
commented
Nov 17, 2020
| { | ||
| if (0 < preg_match("/Content-Type:(\V*)/ims", $response, $match)) { | ||
| $this->contentType = trim($match[1]); | ||
| if (0 < preg_match_all("/content-type: (.+?(?=;|$))/ims", $headers, $match, PREG_SET_ORDER)) { |
There was a problem hiding this comment.
soyuka
force-pushed
the
fix/http-redirects
branch
from
3fa45eb
to
524105d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CurlURIRetriever will fallback to the FileGetContents one with relative paths as I understood that file paths and actual URIs were using the same retriever.
Please let me know if my assumption is false.