JW8-11009 Upgrade TS to 3.8 - Add import type #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these might have been missed: |
2 tasks
jnatalzia
force-pushed
the
chore/upgrade_ts_3.8
branch
from
52c7e3c
to
b0195f5
Compare
robwalch
suggested changes
Mar 23, 2020
There was a problem hiding this comment.
With "importsNotUsedAsValues": "error", in tsconfig:
$ tsc --noEmit
src/js/controller/async-item.ts:4:1 - error TS1371: This import is never used as a value and must use 'import type' because the 'importsNotUsedAsValues' is set to 'error'.
4 import Model from 'controller/model';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/js/controller/async-item.ts:5:1 - error TS1371: This import is never used as a value and must use 'import type' because the 'importsNotUsedAsValues' is set to 'error'.
5 import ApiPublic from 'api/api';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/js/program/shared-media-pool.ts:1:1 - error TS1371: This import is never used as a value and must use 'import type' because the 'importsNotUsedAsValues' is set to 'error'.
1 import { MediaElementPoolInt } from 'program/media-element-pool';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/js/utils/defaults.ts:1:1 - error TS1371: This import is never used as a value and must use 'import type' because the 'importsNotUsedAsValues' is set to 'error'.
1 import { GenericObject } from '../types/generic.type';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/js/view/controls/templates/slider.ts:1:1 - error TS1371: This import is never used as a value and must use 'import type' because the 'importsNotUsedAsValues' is set to 'error'.
1 import { HTMLTemplateString } from 'types/generic.type';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
e3a7ff6
to
038c1d2
Compare
robwalch
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked until babel/babel#11171 is mergedThis PR will...
Upgrade typescript to 3.8
Why is this Pull Request needed?
Lots of cool features to take advantage of
Are there any points in the code the reviewer needs to double check?
Did I miss any
import typesAre there any Pull Requests open in other repos which need to be merged with this?
https://github.com/jwplayer/jwplayer-commercial/pull/7467
Addresses Issue(s):
JW8-11009
Checklist