[#519] Add moditect-generated module-info.java files and a simple IT. #722
Conversation
… IT. - uses lots of more profiles - requires Java 8+ for a release - requires Java 9+ for running the integration test - does not deploy integration tests - maven.compiler.release is set instead of source and target for Java9+ - maven.compiler.source/target is now only set on Java7 and Java8 so the javadoc and sources plugin will work correctly. - Does not contain ITs for neither GSON nor org.json. - Ugly workaround for the fact that the old bundle-plugin crashes on Java9+ module-info.java files, had to provide an empty static MANIFEST.MF file and disable the bundle-plugin on ITs. - I found it odd that the extensions do not reference their correct parent pom as parent pom, instead the root is chosen. This is probably a maven anti-pattern and was corrected by khmarbaise for Shiro. - parentLocation = ../pom.xml is redundant for /api and /impl, but did not bother to correct it here - some pom.xml files were missing a final line break as required by unix spec.
|
Did a quick test: |
|
Just a quick note, and this is probably obvious, but this can't be merged until after a 1.0 release due to the requirement for JDK 8. |
|
@lhazlewood this only requires Java 8 at RELEASE time, not at runtime. Are you sure this is what you intended to say? 🤔 Talked to @bdemers the other day about it. We were thinking of a release profile which included an enforcer check for JDK8. I really don't see why this needs to go into the next major version and couldn't be included in 0.12.0. |
|
Also, you might just have read past my comments mentioning 1.7 profiles and you probably just forgot to start the CI jobs. |
|
Oohhhh I see what you mean now. But it's only for building a release with the moditect files included. It still is running on (read carefully): JRE 7! I updated the description to emphasize the difference between a JDK and JRE and build time and runtime. Of course you know, but I put the blame on me not being a native speaker. 🙈 |
|
Huh… I cannot get the CI to work. Groovy is generating this class public class NoServiceDescriptorClassLoader
extends java.lang.ClassLoader implements
groovy.lang.GroovyObject {
;
public NoServiceDescriptorClassLoader
(java.lang.ClassLoader parent) {
super((java.lang.String) null, (java.lang.ClassLoader) null);
}
}... oddly this fails on zulu-11 and temurin-11, but not on IBM Semeru-11. This is the Semeru Constructor: This for Zulu/Temurin: Will dig into it later. |
Fixes #519 (to be proven)
maven.compiler.releaseis set instead of source and target for Java9+maven.compiler.source/targetis now only set on Java7 and Java8 so the javadoc and sources plugin will work correctly.had to provide an empty static MANIFEST.MF file and disable the bundle-plugin on ITs.
This is probably a maven anti-pattern and was corrected by khmarbaise for Shiro.
<parentLocation />=../pom.xmlis redundant for/apiand/impl, but did not bother to correct it herepom.xmlfiles were missing a final line break as required by unix spec.