Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#519] Add moditect-generated module-info.java files and a simple IT. #722

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Apr 19, 2022

  1. [jwtk#519] Add moditect-generated module-info.java files and a simple…

    … IT.
    
    - uses lots of more profiles
    - requires Java 8+ for a release
    - requires Java 9+ for running the integration test
    - does not deploy integration tests
    - maven.compiler.release is set instead of source and target for Java9+
    - maven.compiler.source/target is now only set on Java7 and Java8 so the javadoc and sources plugin will work correctly.
    - Does not contain ITs for neither GSON nor org.json.
    - Ugly workaround for the fact that the old bundle-plugin crashes on Java9+ module-info.java files,
      had to provide an empty static MANIFEST.MF file and disable the bundle-plugin on ITs.
    - I found it odd that the extensions do not reference their correct parent pom as parent pom, instead the root is chosen.
      This is probably a maven anti-pattern and was corrected by khmarbaise for Shiro.
    - parentLocation = ../pom.xml is redundant for /api and /impl, but did not bother to correct it here
    - some pom.xml files were missing a final line break as required by unix spec.
    bmarwell committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    5bc95b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f323491 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Configuration menu
    Copy the full SHA
    a768897 View commit details
    Browse the repository at this point in the history