Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for supplying multiple public keys, in order to gracefully support certificate rotation #241

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

add support for supplying multiple public keys, in order to gracefully support certificate rotation #241

wants to merge 24 commits into from

Commits on Jul 25, 2017

  1. add support for supplying multiple public keys that will be attempted… 

    … when validating a token signature

this facilitates the supporting of certificate rotation, and there being multiple valid keys available during a rotation cycle
    @thepeachbeetle
    thepeachbeetle committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    ba3ae16 View commit details
    Browse the repository at this point in the history

  2. remove some <>'s and undo some accidental codestyle changes

    @thepeachbeetle
    thepeachbeetle committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    f1e1eec View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2017

  1. tests

    @thepeachbeetle
    thepeachbeetle committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    75bd8a4 View commit details
    Browse the repository at this point in the history

  2. Revert "remove some <>'s and undo some accidental codestyle changes" 

    This reverts commit f1e1eec.
    @thepeachbeetle
    thepeachbeetle committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    b672444 View commit details
    Browse the repository at this point in the history

  3. Revert "add support for supplying multiple public keys that will be a… 

    …ttempted when validating a token signature"

This reverts commit ba3ae16.
    @thepeachbeetle
    thepeachbeetle committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    3374298 View commit details
    Browse the repository at this point in the history

  4. tests

    @thepeachbeetle
    thepeachbeetle committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    e8ba619 View commit details
    Browse the repository at this point in the history

  5. Revert "tests" 

    This reverts commit e8ba619.
    @thepeachbeetle
    thepeachbeetle committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    22830ed View commit details
    Browse the repository at this point in the history

  6. support multiple private keys when validating signature of a token, e… 

    …ach private key will be attempted in turn
    @thepeachbeetle
    thepeachbeetle committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    08edd6f View commit details
    Browse the repository at this point in the history

  7. only retrieve either a single key or a collection of keys from the si… 

    …gning key resolver

this allows existing subclasses of the SigningKeyResolverAdaptor to work un-modified with these changes
the new methods are only necessary to override if you wish to take advantage of the ability to supply a collection of keys
    @thepeachbeetle
    thepeachbeetle committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    c1e9e9e View commit details
    Browse the repository at this point in the history

  8. test coverage

    @thepeachbeetle
    thepeachbeetle committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    ef42b0d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2017

  1. test coverage

    @thepeachbeetle
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    35c674e View commit details
    Browse the repository at this point in the history

  2. re run the tests

    @thepeachbeetle
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    2191bf8 View commit details
    Browse the repository at this point in the history

  3. try both resolveKey and resolveKeys before throwing any exception gen… 

    …erated by the SigningKeyResolverAdaptor
    @thepeachbeetle
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    25860fb View commit details
    Browse the repository at this point in the history

  4. allow both resolveKey and resolveKeys to be evanulated when parsing p… 

    …laintext as well
    @thepeachbeetle
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    3affd83 View commit details
    Browse the repository at this point in the history

  5. additional tests to increase coverage

    @thepeachbeetle
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    c1c25ba View commit details
    Browse the repository at this point in the history

  6. re trigger tests

    @thepeachbeetle
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    1e22d8f View commit details
    Browse the repository at this point in the history

  7. explicitely use a Date for 'expiration' in the testParseRequireExpira… 

    …tion_Success test to address intermittent test failure
    @thepeachbeetle
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    abde7e0 View commit details
    Browse the repository at this point in the history

  8. revert everything

    @thepeachbeetle
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    9f0c6ee View commit details
    Browse the repository at this point in the history

  9. supporting multiple public keys in SigningKeyResolver

    @thepeachbeetle
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    6396313 View commit details
    Browse the repository at this point in the history

  10. Merge pull request #1 from thepeachbeetle/attempt-1 

    Attempt 1
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    c2d34cd View commit details
    Browse the repository at this point in the history

  11. Merge pull request #2 from thepeachbeetle/master 

    merge with master
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    aebb76f View commit details
    Browse the repository at this point in the history

  12. Merge pull request #3 from jwtk/master 

    merge upstream
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    284c001 View commit details
    Browse the repository at this point in the history

  13. Merge pull request #4 from thepeachbeetle/attempt-1 

    Merge pull request #2 from thepeachbeetle/master
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    f3d037e View commit details
    Browse the repository at this point in the history

  14. Merge pull request #5 from thepeachbeetle/master 

    merge with upstream
    thepeachbeetle committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    7bb498f View commit details
    Browse the repository at this point in the history