Audience single string claim data type retention when copying #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout converting it to a `Set`) when copying/applying a source Claims instance to a destination Claims builder. Updated CHANGELOG.md accordingly. Fixes #890.
lhazlewood
commented
Jan 11, 2024
|
|
||
| assertEquals aud, m.get('aud') // single string value | ||
| } | ||
|
|
There was a problem hiding this comment.
@devdanylo and @arvindkrishnakumar-okta
Please feel free to take a look at this PR and the test case immediately above, especially lines 1184, 1185 and 1198.
Tests pass locally, I'm just waiting for CI to verify.
There was a problem hiding this comment.
LGTM, thanks for the quick response!
|
CI passed successfully, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensured a single string
aud(Audience) claim would be retained (without converting it to aSet) when copying/applying a source Claims instance to a destination Claims builder.Updated CHANGELOG.md accordingly.
Fixes #890.