Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIST Elliptic Curve JWKs: field element byte array padding #903

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

lhazlewood
Copy link
Contributor

Ensured NIST Elliptic Curve JWK x, y and d byte array values are padded with leading zero (0x00) bytes if necessary before Base64URL-encoding per length requirements defined in:

Fixes #901.

@lhazlewood lhazlewood added this to the 0.12.4 milestone Jan 26, 2024
* Asserts correct behavior per https://github.com/jwtk/jjwt/issues/901
*/
@Test
void fieldElementByteArrayLength() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@7ing here's the updated/modified version of your test. Thanks for your contribution!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue.

@lhazlewood lhazlewood merged commit 0763191 into master Jan 26, 2024
24 checks passed
@lhazlewood lhazlewood deleted the issue-901 branch January 26, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NIST Elliptic Curve JWK field element octet string padding
2 participants