Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestedCollection changes without .and() #917

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

lhazlewood
Copy link
Contributor

  • Ensured NestedCollections do not need their .and() method called to apply collection changes. Instead, changes are applied immediately as they occur (via .add, .remove, etc), and .and() is now purely for returning to the parent builder if necessary/desired.
  • Updated associated JavaDoc with code examples to make the .and() method's purpose a little clearer.
  • Updated CHANGELOG.md

Closes #916

…d to apply collection changes. Instead, changes are applied immediately as they occur (via `.add`, `.remove`, etc), and `.and()` is now purely for returning to the parent builder if necessary/desired.

* Updated associated JavaDoc with code examples to make the `.and()` method's purpose a little clearer.
* Updated CHANGELOG.md

Closes #916
@lhazlewood lhazlewood added this to the 0.12.5 milestone Jan 31, 2024
@lhazlewood lhazlewood merged commit a0a123e into master Feb 1, 2024
24 checks passed
@lhazlewood lhazlewood deleted the 916-nested-changes branch February 1, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jwts.builder - audience cannot be add without calling add()
1 participant