Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #270

Merged
merged 82 commits into from Mar 10, 2019
Merged

V2 #270

merged 82 commits into from Mar 10, 2019

Conversation

jxnblk
Copy link
Owner

@jxnblk jxnblk commented Mar 8, 2019

Generally speaking, this version should be backwards-compatible with existing decks but makes some breaking changes to the internal APIs and will require changes in third-party add-ons. These changes attempt to provide better theming, styling, and React architecture

  • Uses Reach Router - which fixes focus trap issues
  • Updates to MDX v1
  • Simplified custom mdx loader, removing unused front-matter support
  • Simplified theming and default styles
  • Removes default Provider component with dot indicator
  • Removed PDF export and screenshots from core CLI - now available with the @mdx-deck/export CLI
  • Removed built-in syntax highlighting – now can be added/controlled with themes
  • Removed notes language attribute for fenced code blocks in favor of using the <Notes /> component directl
  • Refactored dev server
  • Support for theme composition
  • Reorganizes repo as a monorepo

Todo

  • Update to MDX v1
  • Fix mdx-plugin for MDX v1
  • Documentation updates
    • README
    • Theme composition
    • Syntax highlighter theme
  • Fix CI tests
  • Clean up styles for presenter and overview modes
  • Add timer and new window link back to presenter mode
  • Check styles for all layouts
  • Test out all themes
  • Potentially leverage MDX multiple mode (RFC: Multiple MDXs in a Single File mdx-js/mdx#454) Will follow up with a separate PR for this

Fixes #243
fixes #258
resolves #264
fixes #265
fixes #243
resolves #238
fixes #177
fixes #157
fixes #93

@jxnblk jxnblk changed the title [WIP] V2 V2 Mar 10, 2019
@jxnblk jxnblk merged commit fff120b into master Mar 10, 2019
@jxnblk jxnblk deleted the v2-monorepo branch March 10, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment