Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNOME 42 support. In sync with upstream. No regressions found. #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Mershl
Copy link

@Mershl Mershl commented Apr 16, 2022

No description provided.

@Mershl
Copy link
Author

Mershl commented Nov 10, 2022

Hi @jylertones,

you still around? For Gnome 43 we'll need to sync a bit to upstream.

EDIT: upstream also errors out for now. Let's wait a bit.
EDIT2: commenting out the AggregateLayout usage makes it work again. Though the layout for the onclick popup is slightly scuffed. Good enough for the moment.

Currently gnome-shell-extension-mpris-indicator-button errors out on startup on Gnome 43:

gnome-shell[1742]: JS ERROR: Extension mprisindicatorbutton@tyler.doublejones.com: TypeError: AggregateLayout is not a constructor
                                               _init@/var/home/mershl/.local/share/gnome-shell/extensions/mprisindicatorbutton@tyler.doublejones.com/widgets.js:1570:40
                                               ButtonBox@resource:///org/gnome/shell/ui/panelMenu.js:11:1
                                               PanelMenuButton@resource:///org/gnome/shell/ui/panelMenu.js:97:4
                                               MprisIndicatorButton@/var/home/mershl/.local/share/gnome-shell/extensions/mprisindicatorbutton@tyler.doublejones.com/widgets.js:1565:3
                                               enable@/var/home/mershl/.local/share/gnome-shell/extensions/mprisindicatorbutton@tyler.doublejones.com/extension.js:41:37
                                               _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:184:32
                                               loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:385:26
                                               _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:633:18
                                               collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:28:28
                                               _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:612:19
                                               _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:639:18
                                               _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:659:14
                                               init@resource:///org/gnome/shell/ui/extensionSystem.js:57:14
                                               _initializeUI@resource:///org/gnome/shell/ui/main.js:309:22
                                               start@resource:///org/gnome/shell/ui/main.js:186:5
                                               @resource:///org/gnome/shell/ui/init.js:6:17

…eam fix.

The on-click popup of the tray icon shows a lightly scuffed layout because of this, not too bad imo.
@jylertones
Copy link
Owner

@Mershl should we still merge this?

@Mershl
Copy link
Author

Mershl commented Oct 7, 2023

Hi @jylertones, Gnome 3.32 until 44 support should be backwards compatible.

I just pushed Gnome 45 support, which is the first upgrade that really breaks support for old versions. I'd recommend using the 44 commit on Gnome 44 and older and the latest on Gnome 45.

no warnings or other breakage found on Fedora 40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants