Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Advanced OS preop into requirements #199

Merged
merged 3 commits into from Nov 20, 2023

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Nov 16, 2023

Addresses: #195

Changes:

  • Move Additonal OS prep in collapsed sections in the Requirements page
  • Add blurb in quickstart linking to requirments page
  • Move Iptables workaround fully into Known Issues page

image

Signed-off-by: Derek Nola derek.nola@suse.com

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
@brandond
Copy link
Contributor

Should we do tabs like we do for the different database engines, instead of collapsable sections?

@dereknola
Copy link
Contributor Author

dereknola commented Nov 17, 2023

So originally in Docusaurus 2.0, it was not possible to have any kind of linking or anchoring for items inside tabs. Thats why I was using the details collapse, because then we could still link direct to Raspberry-Pi in several places. However now that facebook/docusaurus#8225 is merged, Docusaurus 2.3 allows using query-strings allows some level of direct linking, so I will try that out.

Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

@VestigeJ VestigeJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@dereknola dereknola merged commit 18f3ba9 into k3s-io:main Nov 20, 2023
3 checks passed
@dereknola dereknola deleted the firewall_req branch November 20, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants