Update valid resolv conf #9948
Merged
Update valid resolv conf #9948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9948 +/- ##
==========================================
- Coverage 49.63% 43.27% -6.37%
==========================================
Files 158 158
Lines 14017 14020 +3
==========================================
- Hits 6958 6067 -891
- Misses 5755 6791 +1036
+ Partials 1304 1162 -142
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
requested changes
Apr 15, 2024
x-coder-L
force-pushed
the
validate-resolv.conf-nameserver
branch
2 times, most recently
from
f90591e
to
118a9ef
Compare
Co-authored-by: Brad Davidson <brad@oatmail.org> Signed-off-by: linxin <linxin@geedgenetworks.com>
x-coder-L
force-pushed
the
validate-resolv.conf-nameserver
branch
from
118a9ef
to
0c42a21
Compare
brandond
approved these changes
Apr 16, 2024
manuelbuil
approved these changes
Apr 16, 2024
|
We are in code freeze right now preparing for the April releases. This PR will need to go into the May releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate resolv.conf for presence of nameserver entries
Signed-off-by: linxin linxin@geedgenetworks.com
Proposed Changes
Validate resolv.conf for presence of nameserver entries
Adding this validation is necessary to prevent the scenario where not having any upstream is considered invalid.
Types of Changes
New Feature
Verification
Create a resolv.conf without a nameserver and start k3s. If coredns can run, or any pod using the default DNS policy has a resolv.conf with nameserver 8.8.8.8, it means the proposed changes are correct.
Testing
Linked Issues
#9874