Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed stream server bind address for cri-dockerd #9975

Merged

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Apr 18, 2024

Proposed Changes

Use fixed stream server bind address for cri-dockerd

Will now use 127.0.0.1:10010, same as containerd's CRI:

[plugins."io.containerd.grpc.v1.cri"]
stream_server_address = "127.0.0.1"
stream_server_port = "10010"

Types of Changes

enhancement

Verification

  • See linked issue
  • Check for listener on 127.0.0.1:10010 when using cri-dockerd

Testing

Linked Issues

User-Facing Change


Further Comments

Will now use 127.0.0.1:10010, same as containerd's CRI

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner April 18, 2024 23:30
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.52%. Comparing base (81cd630) to head (7c6ca28).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9975      +/-   ##
==========================================
- Coverage   49.63%   43.52%   -6.11%     
==========================================
  Files         158      158              
  Lines       14017    14018       +1     
==========================================
- Hits         6958     6102     -856     
- Misses       5755     6751     +996     
+ Partials     1304     1165     -139     
Flag Coverage Δ
e2etests 36.40% <100.00%> (-9.74%) ⬇️
inttests 37.06% <0.00%> (+0.01%) ⬆️
unittests 16.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 7374010 into k3s-io:master May 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants