Update module sigs.k8s.io/controller-runtime to v0.14.0 - abandoned

[renovate]

This PR contains the following updates:

Package	Type	Update	Change
sigs.k8s.io/controller-runtime	require	minor	v0.13.1 -> v0.14.1

• PR contains the label that identifies the area, one of: area:operator, area:chart
• If the PR is targeting a Helm chart, add the chart label, e.g. chart:k8up

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[renovate]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

[ccremer]

Waiting on kubernetes-sigs/controller-tools#749, which hopefully fixes the x-kubernetes-map-type: Invalid value: "null": must be atomic as item of a list with x-kubernetes-list-type=set errors we see in the CRD generator

[JoelSpeed]

Waiting on kubernetes-sigs/controller-tools#749, which hopefully fixes the x-kubernetes-map-type: Invalid value: "null": must be atomic as item of a list with x-kubernetes-list-type=set errors we see in the CRD generator

Hey, I'm also seeing a similar issue to this because of a new field added to corev1.ResoureRequirements, any more detail on where you're seeing this? Have you tried with an updated controller-tools build, at the moment I don't think this will actually resolve the issue

[ccremer]

Hi @JoelSpeed
I'm seeing this when applying the CRDs, e.g. https://github.com/k8up-io/k8up/actions/runs/3702265650/jobs/6272352806

Have you tried with an updated controller-tools build

No, I haven't investigated this issue further as of now.
I also don't know where a fix is actually needed, might be that it's not in controller-tools itself, or the runtime.

[JoelSpeed]

Ok, so you're using the same type we are.

The validation error we are hitting was introduced in kubernetes/kubernetes@e4e1c2c, specifically we are hitting the object case.

Seems this has been around for a while we just haven't hit it before.
The issue seems to be, that when you have a listType=set on a slice of a struct, it expects that struct to be tagged as structType=atomic (with the default being granular). We have some CRDs importing corev1.ResourceRequirements which recently added a new field, which is a listType=set, but the struct type in the list doesn't have the structType=atomic tag.
The new field and struct were both added within the same PR, so I'm wondering is this an oversight on the PR author that they should have added the structType tag to their struct?

For reference, this is what the correct generated schema looks like, highlighting the missing line as best I can

                        claims:
                          description: "Claims lists the names of resources, defined in spec.resourceClaims, that are used by this container. \n This is an alpha field and requires enabling the DynamicResourceAllocation feature gate. \n This field is immutable."
                          type: array
                          items:
                            description: ResourceClaim references one entry in PodSpec.ResourceClaims.
                            type: object
                            required:
                              - name
                            properties:
                              name:
                                description: Name must match the name of one entry in pod.spec.resourceClaims of the Pod where this field is used. It makes that resource available inside a container.
                                type: string
 >>>>>>>>>>>                x-kubernetes-map-type: atomic <<<<<< This line I had to add manually
                          x-kubernetes-list-type: set

[ccremer]

Thanks for analyzing this!

so I'm wondering is this an oversight on the PR author that they should have added the structType tag to their struct?

Yeah, looks like it.

[renovate]

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

[Kidswiss]

Updated to 0.17.2 last week. I did not notice any errors during the crd generator anymore. Closing.