Replace dprint prettier plugin with WASM plugins and yamlfmt #95
+50
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
commented
May 13, 2024
| @@ -38,4 +38,4 @@ jobs: | |||
| - run: nix develop --command echo 'This step should be done before any other "nix develop" steps because of measuring Nix build time' | |||
| - run: nix develop --command task deps | |||
| - run: nix develop --command task check | |||
| # - run: nix run . -- --version | |||
| # - run: nix run . -- --version | |||
There was a problem hiding this comment.
Looks like similar problem as google/yamlfmt#112
kachick
commented
May 13, 2024
| @@ -21,8 +21,7 @@ jobs: | |||
| - name: Judge | |||
| id: conclusion | |||
| if: >- | |||
| steps.dependabot.outputs.update-type != 'version-update:semver-major' || | |||
| contains(steps.dependabot.outputs.dependency-names, 'DeterminateSystems') | |||
| steps.dependabot.outputs.update-type != 'version-update:semver-major' || contains(steps.dependabot.outputs.dependency-names, 'DeterminateSystems') | |||
There was a problem hiding this comment.
I don't want this result, but yamlfmt can't keep the indent for now
kachick
force-pushed
the
drop-dprint-process-plugins
branch
from
d2c44df
to
e7da4d0
Compare
* Do not add docker plugin: dprint/dprint-plugin-dockerfile#7 * Do not enable nix updater in renovate, use selfup to sync with other CIs
kachick
changed the title
kachick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #92