test: fixes a bug that we could never imitate win32 on other platform

kaelzhang · Aug 14, 2018 · ef2b417 · ef2b417
1 parent 6559ad0
commit ef2b417
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -435,7 +435,7 @@ class Ignore {
     return this.add(pattern)
   }
 
-  //          |           ignored:unignored
+  //          |           ignored : unignored
   // negative |   0:0   |   0:1   |   1:0   |   1:1
   // -------- | ------- | ------- | ------- | --------
   //     0    |  TEST   |  TEST   |  SKIP   |    X
@@ -444,6 +444,7 @@ class Ignore {
   // - SKIP: always skip
   // - TEST: always test
   // - TESTIF: only test if checkUnignored
+  // - X: that never happen
 
   // @param {boolean} whether should check if the path is unignored,
   //   setting `checkUnignored` to `false` could reduce additional

diff --git a/test/ignore.js b/test/ignore.js
@@ -4,14 +4,15 @@ const {test} = require('tap')
 const cases = require('./fixtures/cases')
 
 const IS_WINDOWS = process.platform === 'win32'
-const SHOULD_TEST_WINDOWS = !process.env.IGNORE_TEST_WIN32
-  && IS_WINDOWS
+const SHOULD_TEST_WINDOWS = process.env.IGNORE_TEST_WIN32
+  || IS_WINDOWS
 
 const make_win32 = path => path.replace(/\//g, '\\')
 const ENV_KEYS = [
   'IGNORE_ONLY_FILTER',
   'IGNORE_ONLY_CREATE_FILTER',
-  'IGNORE_ONLY_IGNORES'
+  'IGNORE_ONLY_IGNORES',
+  'IGNORE_ONLY_WIN32'
 ]
 
 const envs = {}
@@ -75,7 +76,8 @@ cases(({
     return
   }
 
-  test(`win32: .filter(): ${description}`, t => {
+  checkSpec('IGNORE_ONLY_WIN32')
+  && test(`win32: .filter(): ${description}`, t => {
     const win_paths = paths.map(make_win32)
 
     const ig = ignore()