Fix critical security issue GHSA-h755-8qp9-cq85 protobufjs Severity Critical 9.8 / 10 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odselsevier
changed the title
odselsevier
changed the title
|
@catYalere @Dieken @brianphillips @tulios @Nevon can we merge this one? |
|
@Nevon could you please release 3.3.1 ? |
|
Bump, snyk ranking my PRs red is triggering me, a release would be greatly appreciated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix critical security issue
GHSA-h755-8qp9-cq85
Severity Critical 9.8/ 10
protobuf.js (aka protobufjs) 6.10.0 until 6.11.4 and 7.0.0 until 7.2.4 allows Prototype Pollution, a different vulnerability than GHSA-g954-5hwp-pp24. A user-controlled protobuf message can be used by an attacker to pollute the prototype of Object.prototype by adding and overwriting its data and functions. Exploitation can involve: (1) using the function parse to parse protobuf messages on the fly, (2) loading .proto files by using load/loadSync functions, or (3) providing untrusted input to the functions ReflectionObject.setParsedOption and util.setProperty. NOTE: this CVE Record is about Object.constructor.prototype. = ...; whereas GHSA-g954-5hwp-pp24 was about Object.proto. = ...; instead.
References
https://nvd.nist.gov/vuln/detail/CVE-2023-36665
protobufjs/protobuf.js#1899
protobufjs/protobuf.js@e66379f
protobufjs/protobuf.js@protobufjs-v7.2.3...protobufjs-v7.2.4
https://github.com/protobufjs/protobuf.js/releases/tag/protobufjs-v7.2.4
https://www.code-intelligence.com/blog/cve-protobufjs-prototype-pollution-cve-2023-36665
https://github.com/protobufjs/protobuf.js/commits/release-6.11.4