Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a multiplier to replace the potentially confusing value_factor #591

Open
mflagler opened this issue Apr 15, 2021 · 7 comments · May be fixed by #884
Open

feat: add a multiplier to replace the potentially confusing value_factor #591

mflagler opened this issue Apr 15, 2021 · 7 comments · May be fixed by #884
Labels
enhancement Something that can be improved feature request New feature or request

Comments

@mflagler
Copy link

Scaling values using the value_factor is too difficult. This should simply be a multiplier, not a factor/exponent of 10 that you want to scale values by. For converting MB to GB or GB to MB it makes it much easier, and for anything that is scaled by 10s then you just multiply by the factor of 10, 100, or 0.1, or 0.01 and it's plain and simple. There should be a pre-scale offset and a post-scale offset for anyone wanting to convert temps between C and F. Then you could pretty much convert between any units anyone should ever need.

@stale
Copy link

stale bot commented Feb 6, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this is still an active issue, please let us know!

@stale stale bot added the stale Stale issue - closed due to inactivity label Feb 6, 2022
@ildar170975 ildar170975 added the enhancement Something that can be improved label Feb 11, 2022
@stale
Copy link

stale bot commented Feb 11, 2022

Still an active issue, got it! Removing stale label.

@ildar170975
Copy link
Collaborator

In the Docs:
image

IMHO the value_factor should be ANY number [-xxx.xxx, +xxx.xxx].
Values like "0.9, 0.5, 0.04" should scale the state down.
Values like "1.2, 25, 400.56" should scale the state up.
Negative values should make the state negative.

Also, should be specified per-entity - #607

@stale stale bot removed the stale Stale issue - closed due to inactivity label Feb 11, 2022
@jlsjonas jlsjonas added the feature request New feature or request label Feb 14, 2022
@jlsjonas jlsjonas changed the title value_factor is confusing feat: add a multiplier to replace the potentially confusing value_factor Feb 14, 2022
@jlsjonas
Copy link
Collaborator

jlsjonas commented Feb 14, 2022

We should add a simpler multiplier (or similar) property and deprecate value_factor to be removed at a later date (also see #608)

@stale
Copy link

stale bot commented Apr 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this is still an active issue, please let us know!

@stale stale bot added the stale Stale issue - closed due to inactivity label Apr 15, 2022
@ildar170975 ildar170975 removed the stale Stale issue - closed due to inactivity label Apr 15, 2022
@RcRaCk2k
Copy link

RcRaCk2k commented May 1, 2022

Yeah, i also need that.

Having costs per kWh and a cost average for the last hour. So the line of costs per kWh is so small that you can not see any changes in the cent-values, so i have to multiply that bei 5 times, so i can see the price changes in the chart.

@Danie10
Copy link

Danie10 commented Aug 22, 2022

I was also looking for this as I have a forecasted solar radiation in W/m2, and it needed to be multiplied by a factor of 15.57 to equate to the same power as the area of my solar panels. Was looking to have a 'value_factor: 15.57' for that entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something that can be improved feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants