feat: add value_multiplier and extend value_factor #608
Conversation
|
Is there anything missing to complete this PR? |
|
@maulwuff I don't think so. |
The review comments need to be addressed before we can merge this. |
There are no review comments..? |
| @@ -5,7 +5,19 @@ import { | |||
| } from './const'; | |||
|
|
|||
| export default class Graph { | |||
| constructor(width, height, margin, hours = 24, points = 1, aggregateFuncName = 'avg', groupBy = 'interval', smoothing = true, logarithmic = false) { | |||
There was a problem hiding this comment.
We should not need to pass valueFactor & valueMultiplier here, they aren't used in the class.
|
|
||
| const x = 10 ** dec; | ||
| return (Math.round(state * value_factor * x) / x).toFixed(dec); | ||
| return (Math.round(state * value_factor * x) / x).toFixed(dec) * value_multipler; |
There was a problem hiding this comment.
The decimals option will not play nicely together with this change as we first round the value and then multiply with the multiplier value. Should apply the multiplier first and then do the rounding.
| @@ -666,12 +667,14 @@ class MiniGraphCard extends LitElement { | |||
| } | |||
| const dec = this.config.decimals; | |||
| const value_factor = 10 ** this.config.value_factor; | |||
| const value_multipler = this.config.value_multipler || 1; | |||
There was a problem hiding this comment.
If we want to add this as an option on the entity config level we need to check the entity specific config here as well.
|
@OmgImAlexis come on, you can fix that ;-) |
|
Please also add documentation for the option in the readme 👍🏼 |
|
Would love to see this in mini-graph-card, currently this prohibits me from making a total power draw card. My total consumption is reported in kW, while individual devices report in W. |
In the meantime you could look at creating a template_sensor and handle the conversion there. |
|
@OmgImAlexis Do you need some help addressing these (minor) comments & getting this merged? |
|
Please check this: #591 (comment) |
|
Great idea, then I can invert the graph to get this result: |
This adds value_multiplier which similarly to the value_factor only it multiplies the value directly. By default it's set to
1.I've also added the
value_factorto the entity itself to allow different factors for each entity. Personally I like this as it allows cards to show more than a single type of data. For example I want to show data usage and power usage on one, the issue is one is in bytes(I want MB) and one is watts(I want KW). I need one to be divided by1024and the other1000.I haven't tested this yet so please let me know if there's anything I need to fix.
Closes #607 and #591