implement more group_by options #833
Conversation
|
Does this work now? I was just looking for this and now sure how to use it. |
It needs to merged, but I use it on my instance already. The grouping isn't perfect for month and year, but works solidly for week. |
|
When is this expected to be released? This is just the thing I've been waiting for! 👍 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi, Thanks a lot for your contribution! And my apologies for the slow review |
Displaying a sensor's state without displaying it's graph
blind-coder
force-pushed
the
blindcoder/master
branch
from
1c180a8
to
e085d48
Compare
|
Hello, I have made the changes, thanks for the input. I'm not familiar with rebase and pushing afterwards, I hope I did it correctly. If not, let me know and I'll file a new PR with properly forked branches from dev. |
|
@blind-coder thanks for the changes! It looks like a few commits from master sneaked in though :) |
|
Hi Jonas,
I'm on a business trip this week and next. I'll chek it out afterwards.
Kind regards,
Benjamin
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
| date.setHours(0, 0, 0); | ||
| break; | ||
| case 'week': | ||
| date.setDate(date.getDate() - date.getDay() + 1); // First day of the week |
There was a problem hiding this comment.
I just flipped through the PRs here and noticed: should this not be the first day of next week at 0h00? See the date case below... The same applies to month and year.
| @@ -488,6 +488,37 @@ state_map: | |||
| label: Detected | |||
| ``` | |||
|
|
|||
| #### Showing additional info on the card | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
Since I added the other comment on the code. Here are three more:
- There seems to have sneaked in some non-English characters. Possibly from uploading the image?
- Should the image be part of the commit?
- Should the new grouping options be documented? If so, I'd suggest to also going on the caveat that month and year will not be 100% accurate, because they use fixed intervals.
|
Still an active issue, got it! Removing stale label. |
3 similar comments
|
Still an active issue, got it! Removing stale label. |
|
Still an active issue, got it! Removing stale label. |
|
Still an active issue, got it! Removing stale label. |
Implement group_by options week, month and year